1686572 - Return OffThreadToken* from DecodeOffThreadScript

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P3)

Description

[Ted Campbell [:tcampbell]]

The DecodeOffThreadScript APIs have both an optional out-param pointer tokenOut and return a bool. Instead the token should just be returned directly to simplify code.

Comment 1

[Ted Campbell [:tcampbell]]

Attachment: Bug 1686572 - Return JS::OffThreadToken* from off-thread script compile. r?arai!

Instead of using both an optional out-param and a boolean return value, we
can simply return the token directly. This is less error-prone and requires
no change to callers that did not use the out-param.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/62acc7bce1c1
Return JS::OffThreadToken* from off-thread script compile. r=arai

Comment 3

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/62acc7bce1c1