1686666 - Sync event.js methods with latest EventUtils.js

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, task, P3)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

We haven't synced the code for a while and as such a lot of new features and bug fixes aren't part of our code. Would be good to do that again.

A first step is done via bug 1686361 for synthesizeMouseAtPoint because it's needed. The rest we can do later given that this might cause side-effects we don't know about yet.

Comment 1

[James Graham [:jgraham]]

Attachment: Bug 1686666 - Make marionette events use EventUtil.js directly,

Rather than copying over the code from EventUtils, load EventUtils.js
into event.js. This is slightly complicated by the fact that
EventUtils.js depends on the existence of a global named window. So
instead of loading the script as a normal component, we need to use
loadSubScript to create an instance of the script with the required
window binding (this is similar to the approach the CDP module uses).

The actual API changes for mouse events are ~trivial, but for key
events things are a little more involved. The code previously (in
effect) called synthesizeKey with the virtual keycode as the aKey
argument. However EventUtils.js documents this as deprecated, so we
switch to providing the actual key, with the KEY_ prefix for
non-printable characters.

To make this easier, all the data about various keys from the
WebDriver spec is collapsed into a single lookup table, rather than
having a table for each interesting property.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b609cc1c05e7
Make marionette events use EventUtil.js directly, r=webdriver-reviewers,whimboo

Comment 3

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/32989 for changes under testing/web-platform/tests

Comment 4

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/b609cc1c05e7

Comment 5

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 6

[Andrej (:aglavic)]

== Change summary for alert #33419 (as of Tue, 01 Mar 2022 20:36:49 GMT) ==

Improvements:

Ratio	Test	Platform	Options	Absolute values (old vs new)
1%	Base Content JS	linux1804-64-shippable-qr		1,827,032.00 -> 1,811,342.00
1%	Base Content JS	macosx1015-64-shippable-qr		1,857,864.00 -> 1,842,781.33
1%	Base Content JS	macosx1015-64-shippable-qr		1,857,810.67 -> 1,842,808.00

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=33419