Open Bug 1686697 Opened 4 years ago Updated 4 years ago

A missing origin directory should not fail LoadQuotaFromCache completely

Categories

(Core :: Storage: Quota Manager, task)

task

Tracking

()

People

(Reporter: sg, Unassigned)

References

(Blocks 1 open bug)

Details

Currently, when we hit a non-existent origin directory in the loop over the metadata entries in LoadQuota at https://searchfox.org/mozilla-central/rev/07342ce09126c513540c1c343476e026cfa907bf/dom/quota/ActorsParent.cpp#4553, the error will propagate and fail LoadQuota completely. This doesn't appear to be the correct reaction.

Instead, the metadata entry should be removed, and processing of other origins should continue.

I discussed about this with Jens. While this bug causes a slow down in temporary storage initialization, it doesn't mean it will always break entire temporary storage initialization. So if there are other higher priority issues, they should be fixed preferably.

Actually, the summary and description aren't correct: The failing line mentioned is inside a sub-function/lambda expresssion LoadQuotaFromCache, and it doesn't fail LoadQuota. It is still questionable if it should fail LoadQuotaFromCache completely, but that's only an issue of the time efficiency of the temporary storage initialization.

Summary: A missing origin directory should not fail LoadQuota completely → A missing origin directory should not fail LoadQuotaFromCache completely
You need to log in before you can comment on or make changes to this bug.