Open Bug 1686707 Opened 4 months ago Updated 4 days ago

Can't set prefs when a profile is provided

Categories

(Testing :: geckodriver, defect)

Default
defect

Tracking

(Fission Milestone:M8)

ASSIGNED
Fission Milestone M8

People

(Reporter: jgraham, Assigned: jgraham, NeedInfo)

References

(Depends on 1 open bug, Blocks 4 open bugs)

Details

Attachments

(3 files, 1 obsolete file)

If the user provides a profile it ought to be possible to set additional prefs in that profile, and to restore the profile at the end of the session so it can be reused without leaking the prefs into future sessions. Currently we just silently ignore the prefs.

Add support for reading the values passed to command line arguments in
mozrunner. This is a little difficult to do exactly like Firefox as
different arguments may be parsed differently. This patch supports the
following forms:

["--arg", "foo"]

["--arg=foo"]

Assignee: nobody → james
Status: NEW → ASSIGNED

Previously we would just ignore the command-line provided profile,
write prefs to a new profile and then use the command line provided
one. That doesn't really make sense.

Now instead we try to write the prefs to the provided profile and
restore it after the test run.

Blocks: 1525106

Setting Fission Milestone to M8 because this bug blocks Fission M8 bug 1680963.

Fission Milestone: --- → M8
Attachment #9211840 - Attachment description: Bug 1686707 - Disable tab-modal alerts in wpt, → Bug 1686707 - Only allow old modal dialogs in wpt,
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/autoland/rev/0ab4fc850e9d
Support reading command line argument values in rust mozrunner, r=webdriver-reviewers,whimboo
https://hg.mozilla.org/integration/autoland/rev/780388f3782d
Make rust mozprofile profile path public, r=webdriver-reviewers,whimboo
https://hg.mozilla.org/integration/autoland/rev/46cbb03eb060
Support writing prefs to a command-line provided profile, r=webdriver-reviewers,whimboo
https://hg.mozilla.org/integration/autoland/rev/ebd4998c14f6
Only allow old modal dialogs in wpt, r=whimboo

Backout changeset for causing marionette failures at test_fission_autostart.py .

Push with failures

Failure log

also failes here python/test_mochitest_integration.py
Failure log

Backout link

Flags: needinfo?(james)
Depends on: 1707876
Attachment #9211840 - Attachment is obsolete: true
You need to log in before you can comment on or make changes to this bug.