1686707 - Can't set prefs when a profile is provided

Status: RESOLVED FIXED

(Testing :: geckodriver, defect)

Description

[James Graham [:jgraham]]

If the user provides a profile it ought to be possible to set additional prefs in that profile, and to restore the profile at the end of the session so it can be reused without leaking the prefs into future sessions. Currently we just silently ignore the prefs.

Comment 1

[James Graham [:jgraham]]

Attachment: Bug 1686707 - Support reading command line argument values in rust mozrunner,

Add support for reading the values passed to command line arguments in
mozrunner. This is a little difficult to do exactly like Firefox as
different arguments may be parsed differently. This patch supports the
following forms:

["--arg", "foo"]

["--arg=foo"]

Comment 2

[James Graham [:jgraham]]

Attachment: Bug 1686707 - Make rust mozprofile profile path public,

Comment 3

[James Graham [:jgraham]]

Attachment: Bug 1686707 - Support writing prefs to a command-line provided profile,

Previously we would just ignore the command-line provided profile,
write prefs to a new profile and then use the command line provided
one. That doesn't really make sense.

Now instead we try to write the prefs to the provided profile and
restore it after the test run.

Comment 4

[Chris Peterson [:cpeterson]]

Setting Fission Milestone to M8 because this bug blocks Fission M8 bug 1680963.

Comment 5

[James Graham [:jgraham]]

Attachment: Bug 1686707 - Only allow old modal dialogs in wpt,

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0ab4fc850e9d
Support reading command line argument values in rust mozrunner, r=webdriver-reviewers,whimboo
https://hg.mozilla.org/integration/autoland/rev/780388f3782d
Make rust mozprofile profile path public, r=webdriver-reviewers,whimboo
https://hg.mozilla.org/integration/autoland/rev/46cbb03eb060
Support writing prefs to a command-line provided profile, r=webdriver-reviewers,whimboo
https://hg.mozilla.org/integration/autoland/rev/ebd4998c14f6
Only allow old modal dialogs in wpt, r=whimboo

Comment 7

[Iulian Moraru]

Backout changeset for causing marionette failures at test_fission_autostart.py .

Push with failures

Failure log

also failes here python/test_mochitest_integration.py
Failure log

Backout link

Comment 8

[Dorel Luca [:dluca]]

Backed out 14 changesets (bug 1686707, bug 1707876, bug 1678044) for Spidermonkey failure. CLOSED TREE

Log:
https://treeherder.mozilla.org/logviewer?job_id=340215481&repo=autoland&lineNumber=45654

Backout:
https://hg.mozilla.org/integration/autoland/rev/532f607c9ca037bdfc9d671a7447b28b19c05c77

Comment 9

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Failed to create upstream wpt PR due to merge conflicts. This requires fixup from a wpt sync admin.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d6c151fa0bba
Support reading command line argument values in rust mozrunner, r=webdriver-reviewers,whimboo
https://hg.mozilla.org/integration/autoland/rev/baffdc510ceb
Make rust mozprofile profile path public, r=webdriver-reviewers,whimboo
https://hg.mozilla.org/integration/autoland/rev/9f13338b2838
Support writing prefs to a command-line provided profile, r=webdriver-reviewers,whimboo

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3b78b12a05c3
Support reading command line argument values in rust mozrunner, r=webdriver-reviewers,whimboo
https://hg.mozilla.org/integration/autoland/rev/e48f46d4cfaf
Make rust mozprofile profile path public, r=webdriver-reviewers,whimboo
https://hg.mozilla.org/integration/autoland/rev/74337795039c
Support writing prefs to a command-line provided profile, r=webdriver-reviewers,whimboo

Comment 12

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/3b78b12a05c3
https://hg.mozilla.org/mozilla-central/rev/e48f46d4cfaf
https://hg.mozilla.org/mozilla-central/rev/74337795039c

Comment 13

[Henrik Skupin [:whimboo][⌚️UTC+2]]

(In reply to Web Platform Test Sync Bot (Matrix: #interop:mozilla.org) from comment #9)

Failed to create upstream wpt PR due to merge conflicts. This requires fixup
from a wpt sync admin.

James, can you please check what's wrong here?

Comment 14

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/29117 for changes under testing/web-platform/tests

Comment 15

[James Graham [:jgraham]]

This didn't actually have any wpt changes, but the backout did. So the bot wasn't too happy. Anyway I've pacified it with an empty PR.

Comment 16

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot