1686716 - Calling event.preventDefault in drop event handler causes a crash after target iframe has been removed

Status: RESOLVED FIXED

(Core :: DOM: Events, defect)

Description

[Kimmo]

Attachment: test.html

User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/87.0.4280.141 Safari/537.36

Steps to reproduce:

I have a page containing an iframe, which will be replaced with other content after a drop event is received in it. When event.preventDefault is called in the drop event handler after the content has been replaced the browser tab will crash.

Minimal reproduction case is attached in test.html

Actual results:

The browser tab crashes.

Expected results:

The drop event handler should run without crashing.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Attachment: Bug 1686716 - Calling event.preventDefault in drop event handler causes a crash after target iframe has been removed, r=masayuki

Outerwindow implements nsIScriptObjectPrincipal.

I need to write still a testcase for this

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=77e17f7d64283b009bf53bf3aa63d3d2dacf653b

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b3636a62369e
Calling event.preventDefault in drop event handler causes a crash after target iframe has been removed, r=masayuki

Comment 5

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/b3636a62369e