1686720 - ensure :screenshot works on page with remote frames when fission is enabled

Status: RESOLVED FIXED

(DevTools :: Console, task, P2)

Description

[Nicolas Chevobbe [:nchevobbe]]

Bug 1678483 will fix the capture-screenshot function on the server, which is used my multiple consumers, including the :screenshot command.

This test should be about adding a test to check that calling :screenshot on a page with a remote frame works as expected.

The test might also include testing :screenshot in combination with the evaluation context selector.

NOTE: We can use/take inspiration from helper_screenshot_node.js to assert the actual result of the screenshot.

Comment 1

[Chris Peterson [:cpeterson]]

Tracking dt-fission-m3-mvp bugs for Fission M7 (blocking Beta experiment).

Comment 2

[Nicolas Chevobbe [:nchevobbe]]

Note that if we move the screenshot actor to the parent process, we'll need an intermediate step for screenshot --selector, in order to retrieve the contentDomReference of the matching node before calling the screenshot actor.

Comment 3

[Nicolas Chevobbe [:nchevobbe]]

this may be a good opportunity to add a test case for Bug 961832, which didn't have any test

Comment 4

[Nicolas Chevobbe [:nchevobbe]]

I'm going to do this before Bug 1678483. The test will probably have a fail-if=fission , which will be removed in Bug 1678483

Comment 5

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1686720 - [devtools] Check :screenshot behaviour on pages with remote frames. r=jdescottes.

This patch modified the existing test for :screenshot ${filename} to actually
check some pixels of the resulting file.
The test document is modified to include 2 iframes, one remote and the other one
on the same origin, with different background colors so we can check in the test
that the content of the iframes are rendered in the screenshot.

We add a fail-if=fission annotation to the test since our screenshot support
does not support rendering remote iframe when fission is enabled. This should
be fixed with the work on Bug 1678483, and the fail-if would highlight that.

Depends on D102595

Comment 6

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1686720 - [devtools] Add a test for :screenshot --selector . r=jdescottes.

This adds a test for the :screenshot command with the --selector argument.
We're also checking that using the command while selecting another target
in the context selector works as expected.
The test is skipped on non-fission since the context selector isn't enabled
when fission is disabled.

Depends on D102596

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0599761d5f1e
[devtools] Check :screenshot behaviour on pages with remote frames. r=jdescottes.
https://hg.mozilla.org/integration/autoland/rev/954440d77ac4
[devtools] Add a test for :screenshot --selector . r=jdescottes.

Comment 8

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/0599761d5f1e
https://hg.mozilla.org/mozilla-central/rev/954440d77ac4