1686779 - remove isSelfSigned from nsIX509Cert

Status: RESOLVED FIXED

(Core :: Security: PSM, enhancement, P1)

Description

[Dana Keeler (she/her) [:keeler]]

nsIX509Cert.isSelfSigned is only used by LocalCertService to verify that the certificate it is using is self-signed. This shouldn't be necessary, because the certificate isn't a trust anchor and an override has to be added for it anyway. Additionally, the certificate in question is already guaranteed to be self-signed because it was either just generated that way or it was retrieved from the database (the code for which checks that it's self-signed).

Comment 1

[Dana Keeler (she/her) [:keeler]]

Attachment: Bug 1686779 - remove isSelfSigned from nsIX509Cert r?rmf

Before this patch, nsIX509Cert.isSelfSigned was only used by LocalCertService
to verify that the certificate it uses is self-signed. This shouldn't have been
necessary, because the certificate isn't a trust anchor and an override has to
be added for it anyway. Additionally, the certificate in question is already
guaranteed to be self-signed because it was either just generated that way or
it was retrieved from the database (the code for which checks that it's
self-signed).

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/413bf149bca3
remove isSelfSigned from nsIX509Cert r=rmf

Comment 3

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/413bf149bca3