Open Bug 1686807 Opened 5 years ago Updated 4 years ago

Refactor primary password re-mask timeout to be testable

Categories

(Firefox :: about:logins, task, P3)

Firefox 86
task

Tracking

()

Tracking Status
firefox86 --- affected

People

(Reporter: tgiles, Unassigned)

References

(Blocks 1 open bug)

Details

(Whiteboard: [passwords:primary-password])

This is a follow up to Bug 1680534 to refactor the primary password re-mask timeout to be testable. The current implementation uses an internal timeout that can't be controlled externally, which makes the timeout not testable. In order to test the re-mask, the test would need to wait five minutes, which is not what we want.

I would want to avoid exposing AUTH_TIMEOUT_MS as a preference, but if that ends up being the solution that works...then I'm okay with it. While this code path isn't critical, it is a path that could easily be regressed.

Severity: -- → S4
Priority: -- → P3
Whiteboard: [passwords:primary-password]
You need to log in before you can comment on or make changes to this bug.