Closed Bug 1686809 Opened 3 years ago Closed 3 years ago

Use Locale.ROOT when calling toLowerCase

Categories

(GeckoView :: General, defect)

Unspecified
All
defect

Tracking

(firefox86 fixed)

RESOLVED FIXED
86 Branch
Tracking Status
firefox86 --- fixed

People

(Reporter: agi, Assigned: agi)

References

Details

Attachments

(1 file)

csadilek brought this up, toLowerCase uses the device Locale when invoked with no arguments, which might cause unexpected consequences when toLowerCase is used on ASCII-compatible strings. We should use Locale.ROOT whenever toLowerCase is not used for user-facing strings.

By default toLowerCase uses the device's Locale, which could have unexpected
consequences on non-en_US locales.

See also
https://github.com/googleapis/google-http-java-client/pull/420#issue-200260049.

Assignee: nobody → agi
Status: NEW → ASSIGNED
Pushed by asferro@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/349adceeb04a
Use Locale.ROOT when calling toLowerCase. r=owlish
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 86 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: