1686811 - Call pickResult even when shouldNavigate payload property is set

Status: RESOLVED FIXED

(Firefox :: Address Bar, enhancement, P2)

Description

[Harry Twyford]

When implementing the shouldNavigate property introduced in bug 1685619, I realized that a provider may want to both navigate and call pickResult. In my case, it was because I wanted to record in telemetry that the user picked the result.

Comment 1

[Harry Twyford]

Attachment: Bug 1686811 - Call pickResult even when shouldNavigate payload property is set. r?daleharvey,adw

Comment 2

[Harry Twyford]

https://treeherder.mozilla.org/jobs?repo=try&revision=11ef24907452b1229722010b4e42ca9953c3a28f&selectedTaskRun=DxkrW9xKQt6NUxDMyK_JIQ.0

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a9646f8eaea8
Call pickResult even when shouldNavigate payload property is set. r=adw

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/a9646f8eaea8

Comment 5

[Atila Butkovits]

Backed out for causing failures on browser_tabToSearch.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/64fceb1ece1670bde8b3453f159556e5072f14d5

Push with failure: https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=dLEc6K3JQ92XeXLIT_fPGg.0&searchStr=windows%2C10%2Cx64%2Copt%2Cmochitests%2Ctest-windows10-64%2Fopt-mochitest-browser-chrome-e10s%2Cbc1&revision=a9646f8eaea80acffe0f89eea7e8871bdaf55664

Failure log: https://treeherder.mozilla.org/logviewer?job_id=326787279&repo=autoland&lineNumber=5392

Comment 6

[Razvan Maries]

Backout has been grafted to central: https://hg.mozilla.org/mozilla-central/rev/dddd2e870b911718d5cbc01cedaeb461a46a7996

Comment 7

[Andrei Oprea [:andreio]]

Attachment: Backed out changeset a9646f8eaea8 (Bug 1686811) for causing failures on browser_tabToSearch.js. a=backout

Comment 8

[Harry Twyford]

New build: https://treeherder.mozilla.org/jobs?repo=try&revision=781a40b311e4384b9be92aff18117ecacb7cad98

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/544a2726c8db
Call pickResult even when shouldNavigate payload property is set. r=adw

Comment 10

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/544a2726c8db

Comment 11

[Harry Twyford]

Comment on attachment 9197191 [details]
Bug 1686811 - Call pickResult even when shouldNavigate payload property is set. r?daleharvey,adw

Beta/Release Uplift Approval Request

• User impact if declined: We will be unable to run an experiment planned for 85.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Small change with tests; narrowly scoped to private APIs developed to run Urlbar experiments.
• String changes made/needed:

Comment 12

[Julien Cristau [:jcristau]]

Comment on attachment 9197191 [details]
Bug 1686811 - Call pickResult even when shouldNavigate payload property is set. r?daleharvey,adw

approved for 85 rc1

Comment 13

[Julien Cristau [:jcristau]]

https://hg.mozilla.org/releases/mozilla-release/rev/bd6a4d4dc304