Closed Bug 1686829 Opened 9 months ago Closed 1 month ago

Crash in [@ mozilla::intl::Localization::AddResourceId]

Categories

(Core :: Internationalization: Localization, defect, P2)

defect

Tracking

()

RESOLVED FIXED
92 Branch
Tracking Status
firefox-esr78 --- wontfix
firefox-esr91 --- wontfix
firefox92 --- fixed

People

(Reporter: mccr8, Assigned: zbraniecki)

References

Details

(Keywords: crash)

Crash Data

Crash report: https://crash-stats.mozilla.org/report/index/1d3e6f00-523c-4ccd-b260-7aa800210113

Reason: SIGSEGV /SEGV_MAPERR

Top 10 frames of crashing thread:

0 libxul.so mozilla::intl::Localization::AddResourceId intl/l10n/Localization.cpp:198
1 libxul.so mozilla::dom::Document::LocalizationLinkAdded dom/base/Document.cpp:4215
2 libxul.so mozilla::dom::HTMLLinkElement::BindToTree dom/html/HTMLLinkElement.cpp:130
3 libxul.so nsINode::InsertChildBefore dom/base/nsINode.cpp:1549
4 libxul.so nsHtml5TreeOperation::Perform parser/html/nsHtml5TreeOperation.cpp:1199
5 libxul.so nsHtml5TreeOpExecutor::RunFlushLoop parser/html/nsHtml5TreeOpExecutor.cpp:495
6 libxul.so nsHtml5ExecutorFlusher::Run parser/html/nsHtml5StreamParser.cpp:176
7 libxul.so mozilla::TaskController::DoExecuteNextTaskOnlyMainThreadInternal xpcom/threads/TaskController.cpp:739
8 libxul.so nsThread::ProcessNextEvent xpcom/threads/nsThread.cpp:1200
9 libxul.so mozilla::ipc::MessagePump::Run ipc/glue/MessagePump.cpp:109

Looks like a null deref crash at mDocumentL10n->AddResourceId(href);. AFAICT, EnsureL10n() doesn't actually ensure that mDocumentL10n is non-null, so maybe there needs to be a null check?

Component: Internationalization → Internationalization: Localization
Priority: -- → P2

I think this has been fixed by bug 1613705 - no reports in 92. I'll close and reopen if needed.

Status: NEW → RESOLVED
Closed: 1 month ago
Resolution: --- → FIXED
Assignee: nobody → zbraniecki
Depends on: 1613705
Target Milestone: --- → 92 Branch
You need to log in before you can comment on or make changes to this bug.