1686845 - Undefined reference when adding an image in composer.

Status: RESOLVED FIXED

(SeaMonkey :: Composer, defect)

Description

[Frank-Rainer Grahl (:frg)]

If you add an image in the composer window and leave the image dialog with ok an undefined reference error for gMsgCompInputElement will be shown in the log for mailnews/compose/content/mailComposeEditorOverlay.xul. gMsgCompInputElement is not initialized in a composer window only in an image dialog created from the mailnews compose window.

moz-do-not-send seems not to be set as a result but this seems to be mostly harmless. Becuase I am unable to test uploading right now I am unsure if it has other implications but not a new error.

For comm-central the code is now in https://searchfox.org/comm-central/source/suite/editor/components/dialogs/content/EdImageLinkLoader.js#54

Comment 1

[Frank-Rainer Grahl (:frg)]

Attachment: 1686845-fixundefinecomposer-2536.patch

[Approval Request Comment]
Regression caused by (bug #): 1316570
User impact if declined: error in the log only it seems.
Testing completed (on m-c, etc.): 2.53.6
Risk to taking this patch (and alternatives if risky): Trivial. Only occurence where this check isn't yet done.
String changes made by this patch: --

Comment 2

[Ian Neal]

Comment on attachment 9197231 [details] [diff] [review]
1686845-fixundefinecomposer-2536.patch

[Triage Comment]
LGTM r/a=me

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/9d27d083ac0a
Check for undefined variable in Composer image dialog. r=IanN

Comment 4

[Frank-Rainer Grahl (:frg)]

https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/ae449c4a347313c6d5c3f170c79ab04e43325c08
Check for undefined variable in Composer image dialog. r=IanN a=IanN