1686873 - CalStorageCalendar should use transactions where possible

Status: NEW

(Calendar :: Provider: Local Storage, enhancement)

Description

[Lasana Murray]

In bug 1671051 I realized the modifyItem() of CalStorageCalendar first deletes data before making updates. This can be dangerous if we have abrupt exits, like the user closing the application or crash etc.

We should look into putting these operations in transactions so failure means the no data is changed.

Comment 1

[Geoff Lankow (:darktrojan)]

I think it's just flushItem and setMetaData, everything else is already in a transaction on account of this.

The pattern is something like this:

this.mDB.beginTransaction();
try {
  …
  this.mDB.commitTransaction();
} catch (ex) {
  this.mDB.rollbackTransaction();
  throw ex;
}