1686888 - Stop building dump_syms

Status: RESOLVED FIXED

(Toolkit :: Crash Reporting, task)

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1686888 - Stop building dump_syms.

Now that we use an external dump_syms, we don't need to build
breakpad's.

This means we also don't need the dump_syms_rust_demangle crate anymore.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/97c55f8706aa
Stop building dump_syms. r=gsvelto

Comment 3

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/97c55f8706aa

Comment 4

[Martin Stránský [:stransky] (ni? me)]

Mike, this change a regression on distro builds, when dump_syms is missing:

/builddir/build/BUILD/firefox-86.0/objdir/_virtualenvs/init_py3/bin/python -m mozbuild.action.dumpsymbols /builddir/build/BUILD/firefox-86.0/objdir/dist/bin/firefox /builddir/build/BUILD/firefox-86.0/objdir/browser/app/firefox_syms.track
Traceback (most recent call last):
File "/usr/lib64/python3.9/runpy.py", line 197, in _run_module_as_main
return _run_code(code, main_globals, None,
File "/usr/lib64/python3.9/runpy.py", line 87, in _run_code
exec(code, run_globals)
File "/builddir/build/BUILD/firefox-86.0/python/mozbuild/mozbuild/action/dumpsymbols.py", line 107, in <module>
sys.exit(main(sys.argv[1:]))
File "/builddir/build/BUILD/firefox-86.0/python/mozbuild/mozbuild/action/dumpsymbols.py", line 103, in main
return dump_symbols(args.library_or_program, args.tracking_file, args.count_ctors)
File "/builddir/build/BUILD/firefox-86.0/python/mozbuild/mozbuild/action/dumpsymbols.py", line 32, in dump_symbols
dump_syms_bin = buildconfig.substs["DUMP_SYMS"]
File "/builddir/build/BUILD/firefox-86.0/python/mozbuild/mozbuild/backend/configenvironment.py", line 275, in getitem
raise KeyError("'%s'" % key)
KeyError: "'DUMP_SYMS'"

Comment 5

[Martin Stránský [:stransky] (ni? me)]

This is may be also caused by Bug 1688849 where rust dump was disabled for 86 but also old dump_syms are not building.

Comment 6

[Mike Hommey [:glandium]]

If you really need to dump symbols (which you may not actually need to, which would be a discussion to have with gsvelto (as in, we now have some processes to import debug info from distros)), you'll need to build the separate dump_syms rust program on your own.