1686918 - Fix non-x86 builds that were broken by bug 1620993

Status: RESOLVED FIXED

(Toolkit :: Crash Reporting, defect)

Description

[Gabriele Svelto [:gsvelto]]

As per title, this requires us to disable the new Rust code on those platforms and leave it enabled only on 32- and 64-bit x86.

Comment 1

[Gabriele Svelto [:gsvelto]]

Attachment: Bug 1686918 - Disable the new Linux minidump writer on all architectures but x86 & x86-64 r=glandium

Comment 2

[Gabriele Svelto [:gsvelto]]

Try run is here: https://treeherder.mozilla.org/#/jobs?repo=try&revision=4cc49c7f12c4702b849f3a4edc3b7b0abe1dcfcb

We don't have them on automation but this should also fix armhf, ppc64le, s390x, etc...

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1620993

Comment 4

[Dan Horák]

The proposed fix unbreaks the build on Fedora 32 on ppc64le and s390x.

Comment 5

[Gabriele Svelto [:gsvelto]]

(In reply to Dan Horák from comment #4)

The proposed fix unbreaks the build on Fedora 32 on ppc64le and s390x.

Thanks for the feedback! The patch fixed building libxul but failed for gtest, this one should fix them both: https://treeherder.mozilla.org/jobs?repo=try&revision=e1d6a22f31799b47a4e985b2e653cfc1ef3fe402

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/046f14fcb485
Disable the new Linux minidump writer on all architectures but x86 & x86-64 r=glandium

Comment 7

[Dan Horák]

FYI - still looks good on ppc64le and s390x

Comment 8

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/046f14fcb485