1686933 - Remove unused sendPacket/sendPacketToThread helpers

Status: RESOLVED FIXED

(DevTools :: Debugger, task, P3)

Description

[Julian Descottes [:jdescottes]]

Those helpers rely on debugger-client::request, but are not used anywhere. Can be removed.

Comment 1

[Julian Descottes [:jdescottes]]

https://searchfox.org/mozilla-central/search?q=sendPacket&path=devtools%2Fclient&case=false&regexp=false

devtools/client/debugger/src/client/firefox/commands.js defines and exports sendPacket.
This sendPacket is only used by devtools/client/debugger/src/utils/dbg.js

devtools/client/debugger/src/utils/dbg.js uses commands.js::sendPacket in its own sendPacket.
dbg.js::sendPacket is used in dbg.js::sendPacketToThread which is unused.
dbg.js::sendPacket is also exported via the "dbg.helpers" object which is set on the window and then potentially used by createDebuggerContext, which looks like a helper for non-debugger tests which need to interact with the debugger.

Probably more cleanup can be done around this helpers object, a lot of things seem unused and outdated.

Comment 2

[Julian Descottes [:jdescottes]]

Attachment: Bug 1686933 - [devtools] Remove unused sendPacket/sendPacketToThread helpers

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d62643e8e360
[devtools] Remove unused sendPacket/sendPacketToThread helpers r=bomsy

Comment 4

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/d62643e8e360