1686936 - Make more typed array code work with large buffers

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P3)

Comment 1

[Jan de Mooij [:jandem]]

Attachment: Bug 1686936 part 1 - Make %TypedArray%.prototype.set work with large buffers. r?anba!

Comment 2

[Jan de Mooij [:jandem]]

Attachment: Bug 1686936 part 2 - Port %TypedArray%.prototype.copyWithin to C++. r?anba!

Merges the self-hosted code and C++ intrinsic and also adds support for
large buffers.

This follows the old code because the current spec looks pretty different.

Depends on D101922

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3e922579936a
part 1 - Make %TypedArray%.prototype.set work with large buffers. r=anba
https://hg.mozilla.org/integration/autoland/rev/fb62a5b51d3c
part 2 - Port %TypedArray%.prototype.copyWithin to C++. r=anba

Comment 4

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/3e922579936a
https://hg.mozilla.org/mozilla-central/rev/fb62a5b51d3c

Comment 5

[Jan de Mooij [:jandem]]

Attachment: Bug 1686936 part 3 - Change some intrinsics to return length values as number. r?anba!

To support lengths > INT32_MAX.

The JITs will need additional changes later on.

Comment 6

[Jan de Mooij [:jandem]]

Attachment: Bug 1686936 part 4 - Make TypedArrayBitwiseSlice work with large buffers. r?anba!

Depends on D102145

Comment 7

[Jan de Mooij [:jandem]]

Attachment: Bug 1686936 part 5 - Make ensureHasBuffer and objectMoved work with large buffers. r?anba!

Depends on D102146

Comment 8

[Jan de Mooij [:jandem]]

Attachment: Bug 1686936 part 6 - Make some iteration code work with large buffers. r?anba!

Depends on D102147

Comment 9

[Jan de Mooij [:jandem]]

Attachment: Bug 1686936 part 7 - Make GetIndexedPropertiesInRange work with large buffers. r?anba!

Both |begin| and |end| are uint32_t so we can just compare to size_t.

Depends on D102148

Comment 10

[Jan de Mooij [:jandem]]

Attachment: Bug 1686936 part 8 - Make IsBufferSource work with large buffers. r?anba!

Depends on D102149

Comment 11

[Jan de Mooij [:jandem]]

Attachment: Bug 1686936 part 9 - Make GetElements work with large buffers. r?anba!

Depends on D102150

Comment 12

[Jan de Mooij [:jandem]]

Attachment: Bug 1686936 part 3 - Clean up setNumber/NumberValue implementations in Value.h. r?anba!

Comment 13

[Jan de Mooij [:jandem]]

Attachment: Bug 1686936 part 10 - Make PossiblyWrappedTypedArrayLength work with large buffers. r?anba!

Comment 14

[Jan de Mooij [:jandem]]

Attachment: Bug 1686936 part 11 - Make {Shared}ArrayBufferSlice work with large buffers. r?anba!

Depends on D102266

Comment 15

[Jan de Mooij [:jandem]]

Attachment: Bug 1686936 part 12 - Make CacheEntry_getBytecode work with large buffers. r?anba!

Comment 16

[Jan de Mooij [:jandem]]

Attachment: Bug 1686936 part 13 - Make SharedObjectMailbox work with large buffers. r?lth!

Note that the union needs the explicit constructor now because BufferSize has one.

Depends on D102268

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1108b34b936d
part 3 - Clean up setNumber/NumberValue implementations in Value.h. r=anba,tcampbell

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5d3476403514
part 4 - Make TypedArrayBitwiseSlice work with large buffers. r=anba
https://hg.mozilla.org/integration/autoland/rev/025ee8bfc497
part 5 - Make ensureHasBuffer and objectMoved work with large buffers. r=anba
https://hg.mozilla.org/integration/autoland/rev/ad668d21ceee
part 6 - Make some iteration code work with large buffers. r=anba
https://hg.mozilla.org/integration/autoland/rev/e881cca27ae7
part 7 - Make GetIndexedPropertiesInRange work with large buffers. r=anba
https://hg.mozilla.org/integration/autoland/rev/c38fe897cf35
part 8 - Make IsBufferSource work with large buffers. r=anba
https://hg.mozilla.org/integration/autoland/rev/65b3f11c33a3
part 9 - Make GetElements work with large buffers. r=anba

Comment 19

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e83fde9d2053
part 10 - Make PossiblyWrappedTypedArrayLength work with large buffers. r=anba
https://hg.mozilla.org/integration/autoland/rev/d93a7a7cab2b
part 11 - Make {Shared}ArrayBufferSlice work with large buffers. r=anba
https://hg.mozilla.org/integration/autoland/rev/60ca56bbe3f6
part 12 - Make CacheEntry_getBytecode work with large buffers. r=anba
https://hg.mozilla.org/integration/autoland/rev/3c7764105a39
part 13 - Make SharedObjectMailbox work with large buffers. r=lth

Comment 20

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/1108b34b936d
https://hg.mozilla.org/mozilla-central/rev/5d3476403514
https://hg.mozilla.org/mozilla-central/rev/025ee8bfc497
https://hg.mozilla.org/mozilla-central/rev/ad668d21ceee
https://hg.mozilla.org/mozilla-central/rev/e881cca27ae7
https://hg.mozilla.org/mozilla-central/rev/c38fe897cf35
https://hg.mozilla.org/mozilla-central/rev/65b3f11c33a3

Comment 21

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/e83fde9d2053
https://hg.mozilla.org/mozilla-central/rev/d93a7a7cab2b
https://hg.mozilla.org/mozilla-central/rev/60ca56bbe3f6
https://hg.mozilla.org/mozilla-central/rev/3c7764105a39