1686963 - 9.17 - 21.6% tsvg_static / tsvgx (linux64-shippable-qr, macosx1014-64-shippable-qr, windows10-64-shippable-qr) regression on push 9efb772f0e094a11aeba6931dcce97a718f82863 (Wed January 13 2021)

Status: RESOLVED WONTFIX

(Core :: SVG, defect)

Description

[Alexandru Ionescu (needinfo me) [:alexandrui]]

Perfherder has detected a talos performance regression from push 9efb772f0e094a11aeba6931dcce97a718f82863. As author of one of the patches included in that push, we need your help to address this regression.

Regressions:

Ratio	Suite	Test	Platform	Options	Absolute values (old vs new)
22%	tsvgx		macosx1014-64-shippable-qr	e10s stylo webrender	244.83 -> 297.71
17%	tsvgx		windows10-64-shippable-qr	e10s stylo webrender	165.24 -> 193.10
17%	tsvgx		windows10-64-shippable-qr	e10s stylo webrender	165.51 -> 192.96
15%	tsvgx		linux64-shippable-qr	e10s stylo webrender	205.76 -> 237.03
9%	tsvg_static		linux64-shippable-qr	e10s stylo webrender	35.55 -> 38.81

Improvements:

Ratio	Suite	Test	Platform	Options	Absolute values (old vs new)
14%	tsvgx		windows10-64-shippable-qr	e10s stylo webrender-sw	235.43 -> 202.83
13%	tsvgx		linux64-shippable-qr	e10s stylo webrender-sw	251.29 -> 219.82
11%	tsvgx		macosx1014-64-shippable-qr	e10s stylo webrender-sw	326.39 -> 291.78

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests. Please follow our guide to handling regression bugs and let us know your plans within 3 business days, or the offending patch(es) will be backed out in accordance with our regression policy.

For more information on performance sheriffing please see our FAQ.

Comment 1

[Robert Longson [:longsonr]]

We had to disable bug 1555356 because of the regressions it caused. If those can all be fixed we can re-enable that code path. At the moment this state is the lesser of two evils unfortunately.

Comment 2

[Jeff Muizelaar [:jrmuizel]]

Yep. This is an intentional switch to previous behaviour.

Comment 3

[Florin Strugariu [:Bebe]]

Guess the browsertime regression has the same fate (WontFIX)

== Change summary for alert #28474 (as of Mon, 18 Jan 2021 05:46:54 GMT) ==

Regressions:

Ratio	Suite	Test	Platform	Options	Absolute values (old vs new)
29%	google-slides	FirstVisualChange	linux64-shippable-qr	cold nocondprof webrender	460.00 -> 593.33
19%	google-slides	FirstVisualChange	macosx1014-64-shippable-qr	cold nocondprof webrender	771.67 -> 920.00
13%	google-slides	SpeedIndex	linux64-shippable-qr	cold nocondprof webrender	853.67 -> 968.83
9%	google-slides	PerceptualSpeedIndex	linux64-shippable-qr	cold nocondprof webrender	972.33 -> 1,064.25
9%	google-slides	ContentfulSpeedIndex	linux64-shippable-qr	cold nocondprof webrender	1,167.83 -> 1,272.17
8%	google-slides	SpeedIndex	macosx1014-64-shippable-qr	cold nocondprof webrender	1,382.54 -> 1,497.92
8%	google-slides	SpeedIndex	macosx1014-64-shippable-qr	cold nocondprof webrender	1,390.00 -> 1,497.50
7%	google-slides	PerceptualSpeedIndex	macosx1014-64-shippable-qr	cold nocondprof webrender	1,457.58 -> 1,566.67

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=28474

Comment 4

[Florin Strugariu [:Bebe]]

and a raptor regression:
== Change summary for alert #28476 (as of Mon, 18 Jan 2021 05:56:03 GMT) ==

Regressions:

Ratio	Suite	Test	Platform	Options	Absolute values (old vs new)
37%	raptor-tp6-slides-firefox-cold	fcp	windows10-64-shippable-qr	nocondprof webrender	558.42 -> 767.33
37%	raptor-tp6-slides-firefox-cold	fcp	windows10-64-shippable-qr	nocondprof webrender	559.79 -> 767.08
8%	raptor-tp6-slides-firefox-cold		windows10-64-shippable-qr	nocondprof webrender	1,076.13 -> 1,165.17

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=28476

Comment 5

[Robert Longson [:longsonr]]

Yes, comment 1 and comment 2 still apply here.