[wpt-sync] Sync PR 27204 - [TablesNG] fix block size distribution over empty rows
Categories
(Core :: Layout: Tables, task, P4)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox86 | --- | fixed |
People
(Reporter: wpt-sync, Unassigned)
References
(Blocks 1 open bug, )
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 27204 into mozilla-central (this bug is closed when the sync is complete).
PR: https://github.com/web-platform-tests/wpt/pull/27204
Details from upstream follow.
b'Aleks Totic <atotic@chromium.org>' wrote:
[TablesNG] fix block size distribution over empty rows
Did not handle block size distribution over empty rows
correctly.
If there are empty constrained, and unconstrained rows,
distribute only over unconstrained rows.
We used to distribute over all empty rows.Row height distribution is tricky. There is no agreement
between browsers on what the right thing to do is.
FF never grows empty rows. Chrome does not distribute
heights specified on TBODY.Bug: 1161157
Change-Id: I7cb2fb76ef4add651c61b10dbf8dd9fa0b58db0b
Reviewed-on: https://chromium-review.googlesource.com/2632154
WPT-Export-Revision: 7c233d2f57d292d5e628a9489d9fcd9d6bf8f574
|
Assignee | |
Updated•5 years ago
|
|
|
Assignee | |
Comment 1•5 years ago
|
||
|
|
Assignee | |
Comment 2•5 years ago
|
||
|
|
Assignee | |
Comment 3•5 years ago
|
||
CI Results
Ran 14 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI
Total 1 tests and 14 subtests
Status Summary
Firefox
OK : 1
PASS: 7[Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview] 8[Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt, GitHub]
FAIL: 6[Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt, GitHub] 7[Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview]
Chrome
OK : 1
PASS: 7
FAIL: 7
Safari
OK : 1
PASS: 7
FAIL: 7
Links
Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base
Details
Firefox-only Failures
/css/css-tables/tentative/table-height-redistribution.html
table 14: FAIL
New Tests That Don't Pass
/css/css-tables/tentative/table-height-redistribution.html
table 2: FAIL (Chrome: FAIL, Safari: FAIL)
table 4: FAIL (Chrome: FAIL, Safari: FAIL)
table 5: FAIL (Chrome: FAIL, Safari: FAIL)
table 6: FAIL (Chrome: FAIL, Safari: FAIL)
table 8: FAIL (Chrome: FAIL, Safari: FAIL)
table 13: FAIL [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview], PASS [Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt, GitHub] (Chrome: PASS, Safari: PASS)
table 14: FAIL (Chrome: PASS, Safari: PASS)
|
||
Comment 5•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/79354fd55f3a
https://hg.mozilla.org/mozilla-central/rev/e4ea1b236999
Description
•