Closed Bug 1687038 Opened 4 years ago Closed 4 years ago

Skeleton UI sometimes appears in headless mode

Categories

(Firefox :: General, defect)

Product:
Firefox
Component:
General
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
86 Branch
Tracking Flags:
Tracking Status
firefox86 --- fixed

People

(Reporter: molly, Assigned: molly)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Bug 1687038 - Disable the skeleton UI when the headless mode environment variable is set. r=dthayer
48 bytes, text/x-phabricator-request
Details | Review

I don't fully understand what's happening here, but at least some browser tests (I noticed this on the tests in /browser/base/contest/test/general/) when run with mach test --headless appear to start the instance under test in headless mode by using the environment variable MOZ_HEADLESS instead of the --headless command line parameter. That means that the skeleton UI is appearing during these tests, because it currently only looks at the command line parameter, so it seems we need to be checking both.

Pushed by mhowell@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/52c247461749 Disable the skeleton UI when the headless mode environment variable is set. r=dthayer

https://hg.mozilla.org/mozilla-central/rev/52c247461749

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox86: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 86 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: