1687118 - Startup crash in [@ mozilla::dom::Promise::MaybeSomething<T>] from mozilla::dom::DocumentL10n::TriggerInitialTranslation

Status: RESOLVED FIXED

(Core :: Internationalization: Localization, defect, P2)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

1242 crashes in the last half year, many of those on startup.

Crash report: https://crash-stats.mozilla.org/report/index/8e46a71c-6245-4cde-8664-8c3f60210116

Reason: EXCEPTION_ACCESS_VIOLATION_READ

Top 10 frames of crashing thread:

0 xul.dll mozilla::dom::Promise::MaybeSomething<JS::Handle<JS::Value>&> dom/promise/Promise.h:322
1 xul.dll mozilla::dom::Promise::MaybeRejectWithUndefined dom/promise/Promise.cpp:505
2 xul.dll mozilla::dom::DocumentL10n::TriggerInitialTranslation dom/l10n/DocumentL10n.cpp:110
3 xul.dll nsHtml5TreeOpExecutor::DidBuildModel parser/html/nsHtml5TreeOpExecutor.cpp:179
4 xul.dll nsHtml5TreeOpExecutor::RunFlushLoop parser/html/nsHtml5TreeOpExecutor.cpp:529
5 xul.dll nsHtml5ExecutorReflusher::Run parser/html/nsHtml5TreeOpExecutor.cpp:70
6 xul.dll mozilla::SchedulerGroup::Runnable::Run xpcom/threads/SchedulerGroup.cpp:146
7 xul.dll mozilla::TaskController::DoExecuteNextTaskOnlyMainThreadInternal xpcom/threads/TaskController.cpp:739
8 xul.dll nsThread::ProcessNextEvent xpcom/threads/nsThread.cpp:1200
9 xul.dll mozilla::ipc::MessagePump::Run ipc/glue/MessagePump.cpp:87

Comment 1

[Zibi Braniecki [:zbraniecki][:gandalf]]

Emilio - Am I correct to assume that this is not Intl::L10n, but DOM category bug?

Comment 2

[Emilio Cobos Álvarez (:emilio)]

No, this is an l10n bug. The mReady promise seems null, so either Init() failed or we're running TriggerInitialTranslation after cycle collection.

Comment 3

[Zibi Braniecki [:zbraniecki][:gandalf]]

thank you!

Comment 4

[Zibi Braniecki [:zbraniecki][:gandalf]]

Attachment: Bug 1687118 - Bail early from DocumentL10n::TriggerInitialTranslation if mReady is not available. r?emilio,nordzilla

Comment 5

[Zibi Braniecki [:zbraniecki][:gandalf]]

Ok, so Init should bail early if mReady fails to initialize, so I'm suspecting cycle collection route.

I could let the initial translation happen and just skip the mReady state setting, but if it is cycle collection, then engaging in translating the UI during shutdown seems pointless.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f172e803d80c
Bail early from DocumentL10n::TriggerInitialTranslation if mReady is not available. r=emilio,nordzilla

Comment 7

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/f172e803d80c

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Please nominate this for ESR approval when you get a chance.

Comment 9

[Zibi Braniecki [:zbraniecki][:gandalf]]

Comment on attachment 9250939 [details]
Bug 1687118 - Bail early from DocumentL10n::TriggerInitialTranslation if mReady is not available. r?emilio,nordzilla

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration:
• User impact if declined: Some volume of shutdown crashes
• Fix Landed on Version: 96
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): It only adds a conditional early bailout
• String or UUID changes made by this patch:

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9250939 [details]
Bug 1687118 - Bail early from DocumentL10n::TriggerInitialTranslation if mReady is not available. r?emilio,nordzilla

Approved for 91.5esr.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr91/rev/e653c1a65363