Closed
Bug 1687174
Opened 3 years ago
Closed 3 years ago
Cleanup CompilationStencil instantiation code
Categories
(Core :: JavaScript Engine, task, P3)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
86 Branch
| Tracking | Status | |
|---|---|---|
| firefox86 | --- | fixed |
People
(Reporter: tcampbell, Assigned: tcampbell)
References
(Blocks 2 open bugs)
Details
Attachments
(5 files)
Various refactorings and cleanups to make the phases of instantiation clearer.
|
Assignee | |
Comment 1•3 years ago
|
||
|
|
Assignee | |
Comment 2•3 years ago
|
||
Depends on D102105
|
|
Assignee | |
Comment 3•3 years ago
|
||
Depends on D102106
|
|
Assignee | |
Comment 4•3 years ago
|
||
Depends on D102107
|
|
Assignee | |
Comment 5•3 years ago
|
||
If we know the Stencil is for a full parse, we can avoid extra traversals
during instantiation. Use the CanLazilyParse method from BytecodeCompiler to
determine if this is definitely a full parse.
Depends on D102108
Pushed by tcampbell@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/871137ddb5ce Clarify phases of CompilationStencil instantiation. r=arai https://hg.mozilla.org/integration/autoland/rev/4f37b29d1b02 Refactor Stencil MaybeInstantiateModule. r=arai https://hg.mozilla.org/integration/autoland/rev/57ae59952b86 Cleanup Stencil InstantiateTopLevel. r=arai https://hg.mozilla.org/integration/autoland/rev/b557ddf495bb Cleanup CompilationGCOutput::functions initialization. r=arai https://hg.mozilla.org/integration/autoland/rev/bad2b6719d73 Avoid extra loops in Stencil instantiation for full parse. r=arai
|
||
Comment 7•3 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/871137ddb5ce
https://hg.mozilla.org/mozilla-central/rev/4f37b29d1b02
https://hg.mozilla.org/mozilla-central/rev/57ae59952b86
https://hg.mozilla.org/mozilla-central/rev/b557ddf495bb
https://hg.mozilla.org/mozilla-central/rev/bad2b6719d73
Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox86:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 86 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•