1687246 - [wayland] Sort displays by ID

Status: RESOLVED FIXED

(Core :: Graphics: Layers, enhancement)

Description

[Robert Mader [:rmader]]

The implementation of screen info in bug 1640053 did not consider any order of displays. While this is technically correct (AFAIK), usually ordering the screens by ID will give a more similar output to it's corresponding X11 equivalent - most importantly an internal display would usually get listed first, with external ones following.

Implement a simple sorting step.

Comment 1

[Robert Mader [:rmader]]

Attachment: Bug 1687246 - [wayland] Sort displays by ID. r=stransky

On Wayland we don't have a specified order of screens. However,
in order to match intuitive expectations and X11 behavior more, order
the reported screen by their Wayland ID, showing them in order as
reported by the Wayland compositor.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/13800697c49a
[wayland] Sort displays by ID. r=stransky

Comment 3

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/13800697c49a

Comment 4

[Andra Esanu (needinfo me)]

== Change summary for alert #28530 (as of Mon, 25 Jan 2021 13:09:30 GMT) ==

Improvements:

Ratio	Suite	Test	Platform	Options	Absolute values (old vs new)
3%	Heap Unclassified		linux1804-64-shippable-qr	tp6	233,810,732.47 -> 227,829,590.32
0.32%	Heap Unclassified		linux1804-64-shippable-qr	tp6	232,868,723.24 -> 232,134,710.78

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=28530