1687264 - Crash in [@ mozilla::net::HttpBackgroundChannelChild::Init]

Status: RESOLVED FIXED

(Core :: Networking: HTTP, defect, P2)

Description

[Gabriele Svelto [:gsvelto]]

Crash report: https://crash-stats.mozilla.org/report/index/079df639-7c1c-48a1-b347-888a60210115

Reason: EXCEPTION_ACCESS_VIOLATION_WRITE

Top 10 frames of crashing thread:

0 xul.dll mozilla::net::HttpBackgroundChannelChild::Init netwerk/protocol/http/HttpBackgroundChannelChild.cpp:44
1 xul.dll mozilla::detail::RunnableMethodImpl<RefPtr<mozilla::DOMMediaStream>, void  xpcom/threads/nsThreadUtils.h:1201
2 xul.dll nsThread::ProcessNextEvent xpcom/threads/nsThread.cpp:1200
3 xul.dll mozilla::net::nsSocketTransportService::Run netwerk/base/nsSocketTransportService2.cpp:1196
4 xul.dll nsThread::ProcessNextEvent xpcom/threads/nsThread.cpp:1200
5 xul.dll mozilla::ipc::MessagePumpForNonMainThreads::Run ipc/glue/MessagePump.cpp:332
6 xul.dll MessageLoop::RunHandler ipc/chromium/src/base/message_loop.cc:327
7 xul.dll MessageLoop::Run ipc/chromium/src/base/message_loop.cc:309
8 xul.dll static nsThread::ThreadFunc xpcom/threads/nsThread.cpp:441
9 nss3.dll _PR_NativeRunThread nsprpub/pr/src/threads/combined/pruthr.c:399

It appears that mChannelChild is NULL, the crash address seems to line up with the offset of mCreateBackgroundChannelFailed if I'm reading it correctly. I found this during nightly crash triage but it's hard to say when it started because crashes seem to go back a while.

Comment 1

[Dragana Damjanovic [:dragana]]

Attachment: Do not use mChannelChild if CreateBackgroundChannel fails

Comment 2

[Dragana Damjanovic [:dragana]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=d98ea29221d1106c226d3359a3f53eaae18fcf78

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/661c1c16aa34
Do not use mChannelChild if CreateBackgroundChannel fails r=necko-reviewers,valentin

Comment 4

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/661c1c16aa34