168727 - cannot close folder with single click on twistie

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Asa Dotzler [:asa]]

cannot close folder with a click on the twisitie. must first double click on the
folder icon or name to close it then single clicks work on the twistie to toggle
open/close states.

Comment 1

[Pierre Chanial]

It seems to be a tree bug. when following the above testcase, I get the
following assertion:
###!!! ASSERTION: bad row: 'aRowIndex >= 0 && aRowIndex < mRows.Count()', file
nsXULTreeBuilder.cpp, line 628
Break: at file nsXULTreeBuilder.cpp, line 628
JavaScript error: 
 line 0: uncaught exception: [Exception... "Component returned failure code:
0x80070057 (NS_ERROR_ILLEGAL_VALUE) [nsITreeView.getParentIndex]"  nsresult:
"0x80070057 (NS_ERROR_ILLEGAL_VALUE)"  location: "JS frame :: <unknown filename>
:: onxblclick :: line 16"  data: no]

This assertion is triggered in tree.xml, in the click event handler
http://lxr.mozilla.org/seamonkey/source/xpfe/global/resources/content/bindings/tree.xml#732
There is no row selected, but after rebuiding the tree 'in bookmarksTree.xml, in
doCommand), b.selection.currentIndex is not equal to -1 as it should be. I've
seen it equal to a number > rowCount

Comment 2

[Pierre Chanial]

arg, the testcase is:
- delete a bookmark in the bm
- click on a twisty

Comment 3

[Pierre Chanial]

fixed

Comment 4

[Asa Dotzler [:asa]]

verified fixed with todays build on win2K