1687294 - Falsy Symbol property value (0, false) erroneously printed as undefined

Status: RESOLVED FIXED

(DevTools :: Console, defect, P2)

Description

[Nicolas Chevobbe [:nchevobbe]]

Steps to reproduce

1. Navigate to `data:text/html,<meta charset=utf8><script>class A { constructor() {this[Symbol()] = 0;this.b = 0;} }; a = new A(); console.dir(a);</script>
2. Open the console`

Expected results

The expanded logged object looks like:

▼ {…}
|  b: 0
|  Symbol(): 0
|  ▶︎ <prototype>: Object { … }

Actual results

the object is logged as:

▼ {…}
|  b: 0
|  Symbol(): undefined
|  ▶︎ <prototype>: Object { … }

---

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Here's the faulty line: https://searchfox.org/mozilla-central/rev/dac45cc7020dfddbcc937827810dd11550c07dc3/devtools/client/shared/components/object-inspector/utils/node.js#555-556 (we should use hasOwnProperty instead of loosely checking the property value)

Comment 2

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1687294 - [devtools] Fix Symbol node value in ObjectInspector. r=bomsy.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/aff3dcc8c40f
[devtools] Fix Symbol node value in ObjectInspector. r=bomsy.

Comment 4

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/aff3dcc8c40f