1687341 - Default the "Remember this decision" checkbox to "true" for the Geolocation permission prompt

Status: RESOLVED WONTFIX

(Firefox :: Site Permissions, task, P2)

Description

[Mike Conley (:mconley) (:⚙️)]

We're in the midst of auditing our doorhangers for UX improvements. One thing that was brought up recently is that most of these doorhangers default the "Remember this decision" checkbox to false, meaning that the user is likely to see those doorhangers again and again for sites they frequently visit which are using that permission.

For geolocation, we'd like to default the "Remember this decision" checkbox to true instead.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

I believe this can be done here: https://searchfox.org/mozilla-central/rev/85f20360d898501f0fac12dd35fe8b7475e01848/browser/modules/PermissionUI.jsm#714-717

The popupOptions getter that we're manipulating here is a function that returns an object that is ultimately passed to PopupNotifications. Here's the documentation for the options object: https://searchfox.org/mozilla-central/rev/85f20360d898501f0fac12dd35fe8b7475e01848/toolkit/modules/PopupNotifications.jsm#418-531

So what we were doing was showing or hiding the checkbox depending on whether it was for a private browsing window or a file URI. In the event that we're showing the checkbox, we can update its default state to checked by setting options.checkbox.checked to true.

There's evidence to suggest that the geolocation permission panel is tested in a bunch of places: https://searchfox.org/mozilla-central/search?q=geolocation&path=test&case=false&regexp=false

We should obviously ensure that the tests still pass with this change, and investigate / update the ones that don't.

Comment 2

[Emma Malysz]

Attachment: Bug 1687341, checkbox should be checked by default for Geolocation permission prompt

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/102b2b2b5a4c
checkbox should be checked by default for Geolocation permission prompt r=mconley

Comment 4

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/102b2b2b5a4c

Comment 5

[Mike Conley (:mconley) (:⚙️)]

It turns out I misinterpreted part of a conversation with johannh about this - we're not 100% sure this is the way we want to go with this permission panel. I'm going to request a backout until I can get that sorted.

Comment 6

[Cristian Brindusan [:cbrindusan]]

Backed out changeset 102b2b2b5a4c (Bug 1687341) as requested by mconley on irc.
https://hg.mozilla.org/integration/autoland/rev/1b1eba0ebc4f1c1d32ee5fc7ac606ea882be0b67

Comment 7

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Backout merged: https://hg.mozilla.org/mozilla-central/rev/1b1eba0ebc4f

Comment 8

[Emma Malysz]

Hey Mike! Did we ever sort this out?

Comment 9

[Mike Conley (:mconley) (:⚙️)]

Thanks for reminding me! I think the permission doorhanger stuff is still a ways out. Gonna close this one out as WONTFIX for now until we have concrete direction.