Reduce size of XDR FunctionKey
Categories
(Core :: JavaScript Engine, task, P3)
Tracking
()
Tracking | Status | |
---|---|---|
firefox86 | --- | fixed |
People
(Reporter: tcampbell, Assigned: tcampbell)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
The FunctionKey is currently 64-bits and is composed of a start,end pair. Is the second value even needed or is the start offset sufficiently unique? We should be able to use a 32-bit value here.
This would reduce overhead of delazification stencils.
Assignee | ||
Comment 1•3 years ago
•
|
||
This should work. The sourceEnd
doesn't provide any further information.
The script-source-extent test shows a number of the potentially issues, and it looks fine. The one particularly tricky one is lazy arrow functions in default argument expressions, but only one of these is ever delazified.
Edit: One edge case will be () => {};
where the function starts at 0 which is currently the null key. This is easy to fix though.
Assignee | ||
Comment 2•3 years ago
|
||
The sourceEnd
doesn't help with uniqueness so don't include in the key in
order to save space. A function may start in beginning of script, so add 1 to
the sourceStart to generate the key.
Pushed by tcampbell@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/14a41aec9db8 Use uint32_t for Stencil FunctionKey. r=arai
Comment 4•3 years ago
|
||
Backed out changeset 14a41aec9db8 (bug 1687400) for Valgrind failure. CLOSED TREE
Log:
https://treeherder.mozilla.org/logviewer?job_id=327167769&repo=autoland&lineNumber=58738
Backout:
https://hg.mozilla.org/integration/autoland/rev/0ac6c7e669a83788a44d08cb255383bd83621a38
Pushed by dluca@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/0478698744b1 Use uint32_t for Stencil FunctionKey. r=arai CLOSED TREE
Assignee | ||
Comment 6•3 years ago
|
||
False alarm. We should be able to reland now :)
Comment 7•3 years ago
|
||
bugherder |
Description
•