1687433 - Remove unnecessary no-integrated-as flags

Status: RESOLVED FIXED

(Firefox Build System :: General, task)

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1687433 - Don't build libffi assembly with -no-integrated-as.

Back when the flag was added, the libffi source code didn't build for
ARM with the clang integrated assembler. That has been fixed with the
upgrade to libffi v3.3 in bug 1659906, so we can use the integrated
assembler now.

Comment 2

[Mike Hommey [:glandium]]

Attachment: Bug 1687433 - Remove -no-integrated-as flag from libaom and libvpx.

Back when it was added, it was added to libvpx, and the clang base
version was older. Either newer version of clang fixed the issues or
the libvpx source fixed it, but we don't need the flag anymore for
libvpx.

The flag for libaom was cargo culted from libvpx, but may not have been
necessary in the first place. Or maybe it was, but things fixed
themselves in a similar manner. Either way, the flag is not necessary.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0986e09480e6
Don't build libffi assembly with -no-integrated-as. r=firefox-build-system-reviewers,mhentges
https://hg.mozilla.org/integration/autoland/rev/729bf6049b7d
Remove -no-integrated-as flag from libaom and libvpx. r=firefox-build-system-reviewers,mhentges

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/0986e09480e6
https://hg.mozilla.org/mozilla-central/rev/729bf6049b7d