1687461 - Enable SOURCE Watcher on the server for all target types

Status: RESOLVED FIXED

(DevTools :: Debugger, enhancement, P3)

Description

[Alexandre Poirot [:ochameau] [PTO back August 21]]

Today, the SOURCE resource is only implement for tab toolboxes on the server side.
This is being controled by the following trait:
https://searchfox.org/mozilla-central/rev/c54c71ecbd9e64cafc0df3b596e206ac4072cb91/devtools/server/actors/watcher.js#154

We should enable this trait unconditionaly and fix any edge case related to worker and process targets.

Some comments from Julian who tried to enable this traits for the browser toolbox:

• defining a dummy attach for content-process-target actors
• bailing out if targetActor.getFront("thread") doesn't return anything (looks like I have worker targets with no thread attached? haven't investigated)

Comment 1

[Alexandre Poirot [:ochameau] [PTO back August 21]]

A try run, just toggling the trait:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=e4317ba2d1b93976679318ceefe366534e40a468

Comment 2

[Alexandre Poirot [:ochameau] [PTO back August 21]]

https://treeherder.mozilla.org/jobs?repo=try&selectedTaskRun=H1R0zyJkQCmw92-ilp1znw.0&revision=072496d1ae8cfa92c74ff93881babf56d3610555

Comment 3

[Alexandre Poirot [:ochameau] [PTO back August 21]]

Attachment: Bug 1687461 - [devtools] Enable SOURCE resource on all targets

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:ochameau, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 5

[Nicolas Chevobbe [:nchevobbe]]

Alex, did you wanted to wait for something before landing your patch for this?

Comment 6

[Alexandre Poirot [:ochameau] [PTO back August 21]]

Yes, time to test this some more before landing.
Given the issues leveraged by the console message enabling, this patch may suffer from the same issues.

But this isn't a priority compared to M7/bfcache/server side target switching.

Comment 7

[Chris Peterson [:cpeterson]]

dt-fission-future bugs don't need to block Fission MVP, so I'm moving them to Fission Future.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9e49f83ddfaf
[devtools] Enable SOURCE resource on all targets r=nchevobbe,devtools-backward-compat-reviewers,bomsy

Comment 9

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/9e49f83ddfaf