168751 - GRE and MfcEmbed paths should include mozilla.org, not Mozilla

Status: VERIFIED FIXED

(Core Graveyard :: Installer: GRE, defect)

Description

[Curt Patrick (gone)]

The default install paths should be 
  <program_folder>\mozilla.org\GRE\<version> 
  <program_folder>\mozilla.org\MfcEmbed.

The Windows registry path should be:
  HKLM\Software\mozilla.org\GRE (<version>)
  HKLM\Software\mozilla.org\MfcEmbed.

Further, I think that MfcEmbed should be setting the following keys:
  HKLM\Software\Mozilla\MfcEmbed\bin\PathToExe
  HKLM\Software\Mozilla\MfcEmbed\Extensions\Components
  HKLM\Software\Mozilla\MfcEmbed\Extensions\Plugins

Changing the Windows registry path for GRE will probably break MfcEmbed, so Chak
and I need to coordinate on this.

Comment 1

[Chak Nanga]

Hi Curt...let's first make sure that the Mozilla installer defaults to using
"mozilla.org" instead of "Mozilla" in the registry and as a default path before
proceeding with the GRE changes....thanks

Comment 2

[Curt Patrick (gone)]

Attachment: Patch 1

This patch is mostly removal of obsolete scripting code that resulted in
references to Mozilla which were irrelevant.  The substantive changes are:

- Chak's one-line modification to the MfcEmbed code.
- makeall.pl files for both Gre and MfcEmbed:  
  - Changed the CompanyName variable to be mozilla.org.
  - Define the MainExeFile variable for MfcEmbed.
- mfcembed.jst:  Added the registry settings for Software\Mozilla.
- runapp.bat: Corrected the PATH variable.

Comment 3

[[e-mail] (away - not reading bugmail)]

Comment on attachment 99457 [details] [diff] [review]
Patch 1

r=jbetak

Curt, all these changes look good to me. It seems that the largest chunk of the
patch  removes references to Quick Launch and Desktop integration, which is
fine.

The only thing I wasn't really sure of was the new procedure
registerMozillaKeys(winreg) in mfcembed.jst.

Is it supposed to mirror
http://lxr.mozilla.org/seamonkey/source/xpinstall/packager/windows/browser.jst#
282
?

Seems like we don't want to switch horses midstream and start using
"mozilla.org" as the new regkey. Right?

Comment 4

[[e-mail] (away - not reading bugmail)]

oh, I've just read comment #1 and I'm a little confused. Shouldn't
"SOFTWARE\\Mozilla" be SOFTWARE\\$ProductName$?

Comment 5

[Curt Patrick (gone)]

The Mozilla key and the mozilla.org serve two different purposes.  The
mozilla.org/MfcEmbed key, using the company name, is where the mozilla.org
product called MfcEmbed registers keys it needs to operate correctly.  On the
other hand, the Mozilla key is where Mozilla based browser publish information
about themselves that other Mozilla based browser may need to know, esp., I
believe, for migration.

Comment 6

[Daniel Veditz [:dveditz]]

Comment on attachment 99457 [details] [diff] [review]
Patch 1

>Index: embedding/tests/mfcembed/winEmbedFileLocProvider.cpp
>===================================================================
>-    strcpy(szKey, "Software\\Mozilla\\GRE\\1.2b");
>+    strcpy(szKey, "Software\\mozilla.org\\GRE\\1.2b");

Nothing wrong with your patch, but this seems like the wrong thing
to be doing here: someone has to remember to update this code manually
every 5 weeks or so.

I also thought GRE versioning was going to be a three-part
X.Y.Z type scheme (where "Z" is probably the build number),
or is that level of detail somewhere else?

>Index: xpinstall/packager/win_gre/makeall.pl

Too bad you didn't get to bug 22062, you could have saved
all this duplication, and the GRE files could have lived
in embedding setting a good example.

sr=dveditz

Comment 7

[Chak Nanga]

>+ strcpy(szKey, "Software\\mozilla.org\\GRE\\1.2b");

Regrading Dan's comment about hardcoding the version number in the code...

When fixed, http://bugzilla.mozilla.org/show_bug.cgi?id=168580 will address the
issue of automatically updating Mozilla versions

Comment 8

[Curt Patrick (gone)]

Checked in to trunk.

Comment 9

[Charles Rosendahl]

This particular bug is verified - mozilla.org is used in the registry.

All other bugs - versioning conventions, etc.  should be filed separately.