1687592 - L10nMutations::StartRefreshObserver() should not register itself on a refresh driver without a prescontext

Status: RESOLVED FIXED

(Core :: Internationalization: Localization, defect, P2)

Description

[Markus Stange [:mstange]]

The crash stacks from bug 1684788 indicate that there are cases where L10nMutations::StartRefreshObserver() can attempt to register itself as a refresh driver, on a refresh driver which does not have a prescontext.

Mats said:

It feels wrong to add an observer on a RefreshDriver that's been detached from its PresContext - presumably because we're in the process of destroying it?

Comment 1

[Zibi Braniecki [:zbraniecki][:gandalf]]

Thank you for reporting that!

Comment 2

[Zibi Braniecki [:zbraniecki][:gandalf]]

Attachment: Bug 1687592 - Don't cache mRefreshDriver between L10nMutation observer calls. r?nordzilla,mstange

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/72ff13b5fc7e
Don't cache mRefreshDriver between L10nMutation observer calls. r=nordzilla,mstange

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/72ff13b5fc7e