1687618 - Remove browser.cache.cache_isolation

Status: RESOLVED FIXED

(Core :: Networking, task, P2)

Description

[Anne (:annevk)]

It's superseded by privacy.partition.network_state.

Comment 1

[Valentin Gosu [:valentin] (he/him) {{ AFK in July }}]

Attachment: Bug 1687618 - Remove browser.cache.cache_isolation r=#necko

Comment 2

[Valentin Gosu [:valentin] (he/him) {{ AFK in July }}]

Attachment: Bug 1687618 - Remove isolated bit from nsHttpConnectionInfo r=#necko

Depends on D102711

Comment 3

[Valentin Gosu [:valentin] (he/him) {{ AFK in July }}]

Attachment: Bug 1687618 - Remove topWindowOrigin from nsHttpConnectionInfo r=#necko

Depends on D102712

Comment 4

[Valentin Gosu [:valentin] (he/him) {{ AFK in July }}]

Attachment: Bug 1687618 - Remove isolated and topWindowOrigin from altServices r=#necko

Depends on D102713

Comment 5

[Valentin Gosu [:valentin] (he/him) {{ AFK in July }}]

Attachment: Bug 1687618 - Remove implementation of IsIsolated and TopWindowOrigin r=#necko

Depends on D102714

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/984a9f8e8b5e
Remove browser.cache.cache_isolation r=necko-reviewers,dragana
https://hg.mozilla.org/integration/autoland/rev/5308d27acd05
Remove isolated bit from nsHttpConnectionInfo r=necko-reviewers,dragana
https://hg.mozilla.org/integration/autoland/rev/0cb1cb5bf7a8
Remove topWindowOrigin from nsHttpConnectionInfo r=necko-reviewers,dragana
https://hg.mozilla.org/integration/autoland/rev/b67677b3f710
Remove isolated and topWindowOrigin from altServices r=necko-reviewers,dragana
https://hg.mozilla.org/integration/autoland/rev/afb6bcdbdf4f
Remove implementation of IsIsolated and TopWindowOrigin r=necko-reviewers,dragana

Comment 7

[Sandor Molnar[:smolnar]]

Backed out for causing mochitest failures in browser_networkIsolation.

Backout link: https://hg.mozilla.org/integration/autoland/rev/5ef38ba2390212c19d001e2884a06b0c6188d9ad

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Crunning%2Cpending%2Crunnable&searchStr=os%2Cx%2C10.14%2Cwebrender%2Copt%2Cmochitests%2Ctest-macosx1014-64-qr%2Fopt-mochitest-browser-chrome-e10s%2Cbc7&revision=afb6bcdbdf4f7345d8b683ca7d3337fcebf27d81&selectedTaskRun=dmRg9ph5RKWVjuDYmvrZYA.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=327798786&repo=autoland&lineNumber=3892

"INFO - TEST-PASS | toolkit/components/antitracking/test/browser/browser_networkIsolation.js | Found the expected number of items in the cache -
[task 2021-01-26T08:46:48.414Z] 08:46:48 INFO - Buffered messages finished
[task 2021-01-26T08:46:48.414Z] 08:46:48 INFO - TEST-UNEXPECTED-FAIL | toolkit/components/antitracking/test/browser/browser_networkIsolation.js | We expected to find a non-isolated item -
[task 2021-01-26T08:46:48.414Z] 08:46:48 INFO - Stack trace:
[task 2021-01-26T08:46:48.414Z] 08:46:48 INFO - chrome://mochikit/content/browser-test.js:test_ok:1323
[task 2021-01-26T08:46:48.414Z] 08:46:48 INFO - chrome://mochitests/content/browser/toolkit/components/antitracking/test/browser/browser_networkIsolation.js:checkAltSvcCache:108
[task 2021-01-26T08:46:48.414Z] 08:46:48 INFO - chrome://mochitests/content/browser/toolkit/components/antitracking/test/browser/browser_networkIsolation.js:null:126
[task 2021-01-26T08:46:48.414Z] 08:46:48 INFO - Not taking screenshot here: see the one that was previously logged
[task 2021-01-26T08:46:48.414Z] 08:46:48 INFO - TEST-UNEXPECTED-FAIL | toolkit/components/antitracking/test/browser/browser_networkIsolation.js | Found the expected number of items in the cache - Got 1, expected 2"

Comment 8

[Valentin Gosu [:valentin] (he/him) {{ AFK in July }}]

It seems try auto doesn't really cover as much as I'd like 🙂

Comment 9

[Valentin Gosu [:valentin] (he/him) {{ AFK in July }}]

Attachment: Bug 1687618 - Remove browser_networkIsolation.js r=baku

This test checked the implementation of cache_isolation by checking the
values of the hashing keys. This has been removed in favour of
privacy.partition.network_state (Bug 1590107)

Depends on D102715

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a3e036ca4df7
Remove browser.cache.cache_isolation r=necko-reviewers,dragana
https://hg.mozilla.org/integration/autoland/rev/79e739fa8a6c
Remove isolated bit from nsHttpConnectionInfo r=necko-reviewers,dragana
https://hg.mozilla.org/integration/autoland/rev/be4a98cebee0
Remove topWindowOrigin from nsHttpConnectionInfo r=necko-reviewers,dragana
https://hg.mozilla.org/integration/autoland/rev/b5ddfd9ca753
Remove isolated and topWindowOrigin from altServices r=necko-reviewers,dragana
https://hg.mozilla.org/integration/autoland/rev/41e741a5e26c
Remove implementation of IsIsolated and TopWindowOrigin r=necko-reviewers,dragana
https://hg.mozilla.org/integration/autoland/rev/20415e9ca3bf
Remove browser_networkIsolation.js r=baku

Comment 11

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/a3e036ca4df7
https://hg.mozilla.org/mozilla-central/rev/79e739fa8a6c
https://hg.mozilla.org/mozilla-central/rev/be4a98cebee0
https://hg.mozilla.org/mozilla-central/rev/b5ddfd9ca753
https://hg.mozilla.org/mozilla-central/rev/41e741a5e26c
https://hg.mozilla.org/mozilla-central/rev/20415e9ca3bf