Closed Bug 1687752 Opened 5 years ago Closed 5 years ago

[wpt-sync] Sync PR 27258 - Checking if resizeWidth or resizeHeight are 0 when creating Bitmap

Categories

(Core :: DOM: Core & HTML, task, P4)

Product:
Core
Component:
DOM: Core & HTML
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
86 Branch
Tracking Flags:
Tracking Status
firefox86 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(Blocks 1 open bug,
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 27258 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/27258
Details from upstream follow.

b'Juanmi Huertas <juanmihd@chromium.org>' wrote:

Checking if resizeWidth or resizeHeight are 0 when creating Bitmap

According to the standard https://html.spec.whatwg.org/multipage/imagebitmap-and-animations.html
when creating a new ImageBitmap that has resizeWidth or resizeHeight
equal to 0, it has to throw an exception.

As in some cases, user can provide value between 0 and 1, these will be
rounded down to zero (as according to the standard those resizeWidth and
resizeHeight is a unsigned long, so it cannot have decimal values).

Bug: 1137216
Change-Id: I4a0b241fa8a94cc6b59c77bb1313f7a4d7983733
Reviewed-on: https://chromium-review.googlesource.com/2636373
WPT-Export-Revision: 6271d8f110827b689857948d943326cc1007f591

Component: web-platform-tests → DOM: Core & HTML
Product: Testing → Core

CI Results

Ran 14 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 93 subtests

Status Summary

Firefox

OK : 1
PASS: 44
FAIL: 49

Chrome

OK : 1
PASS: 85
FAIL: 8

Safari

OK : 1
PASS: 60
FAIL: 33

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

/html/canvas/element/manual/imagebitmap/createImageBitmap-invalid-args.html
createImageBitmap with an HTMLCanvasElement source and a value of 0 int resizeWidth: FAIL
createImageBitmap with an HTMLCanvasElement source and a value of 0 in resizeHeight: FAIL
createImageBitmap with an HTMLCanvasElement source and a value between 0 and 1 in resizeWidth: FAIL
createImageBitmap with an HTMLCanvasElement source and a value between 0 and 1 in resizeHeight: FAIL
createImageBitmap with an HTMLVideoElement source and a value of 0 int resizeWidth: FAIL
createImageBitmap with an HTMLVideoElement source and a value of 0 in resizeHeight: FAIL
createImageBitmap with an HTMLVideoElement source and a value between 0 and 1 in resizeWidth: FAIL
createImageBitmap with an HTMLVideoElement source and a value between 0 and 1 in resizeHeight: FAIL
createImageBitmap with an HTMLVideoElement from a data URL source and a value of 0 int resizeWidth: FAIL
createImageBitmap with an HTMLVideoElement from a data URL source and a value of 0 in resizeHeight: FAIL
createImageBitmap with an HTMLVideoElement from a data URL source and a value between 0 and 1 in resizeWidth: FAIL
createImageBitmap with an HTMLVideoElement from a data URL source and a value between 0 and 1 in resizeHeight: FAIL
createImageBitmap with a bitmap HTMLImageElement source and a value of 0 int resizeWidth: FAIL
createImageBitmap with a bitmap HTMLImageElement source and a value of 0 in resizeHeight: FAIL
createImageBitmap with a bitmap HTMLImageElement source and a value between 0 and 1 in resizeWidth: FAIL
createImageBitmap with a bitmap HTMLImageElement source and a value between 0 and 1 in resizeHeight: FAIL
createImageBitmap with an ImageData source and a value of 0 int resizeWidth: FAIL
createImageBitmap with an ImageData source and a value of 0 in resizeHeight: FAIL
createImageBitmap with an ImageData source and a value between 0 and 1 in resizeWidth: FAIL
createImageBitmap with an ImageData source and a value between 0 and 1 in resizeHeight: FAIL
createImageBitmap with an ImageBitmap source and a value of 0 int resizeWidth: FAIL
createImageBitmap with an ImageBitmap source and a value of 0 in resizeHeight: FAIL
createImageBitmap with an ImageBitmap source and a value between 0 and 1 in resizeWidth: FAIL
createImageBitmap with an ImageBitmap source and a value between 0 and 1 in resizeHeight: FAIL
createImageBitmap with a Blob source and a value of 0 int resizeWidth: FAIL
createImageBitmap with a Blob source and a value of 0 in resizeHeight: FAIL
createImageBitmap with a Blob source and a value between 0 and 1 in resizeWidth: FAIL
createImageBitmap with a Blob source and a value between 0 and 1 in resizeHeight: FAIL
createImageBitmap with CanvasRenderingContext2D image source.: FAIL

New Tests That Don't Pass

/html/canvas/element/manual/imagebitmap/createImageBitmap-invalid-args.html
createImageBitmap with an HTMLCanvasElement source and a value of 0 int resizeWidth: FAIL (Chrome: PASS, Safari: PASS)
createImageBitmap with an HTMLCanvasElement source and a value of 0 in resizeHeight: FAIL (Chrome: PASS, Safari: PASS)
createImageBitmap with an HTMLCanvasElement source and a value between 0 and 1 in resizeWidth: FAIL (Chrome: PASS, Safari: PASS)
createImageBitmap with an HTMLCanvasElement source and a value between 0 and 1 in resizeHeight: FAIL (Chrome: PASS, Safari: PASS)
createImageBitmap with an HTMLVideoElement source and a value of 0 int resizeWidth: FAIL (Chrome: PASS, Safari: PASS)
createImageBitmap with an HTMLVideoElement source and a value of 0 in resizeHeight: FAIL (Chrome: PASS, Safari: PASS)
createImageBitmap with an HTMLVideoElement source and a value between 0 and 1 in resizeWidth: FAIL (Chrome: PASS, Safari: PASS)
createImageBitmap with an HTMLVideoElement source and a value between 0 and 1 in resizeHeight: FAIL (Chrome: PASS, Safari: PASS)
createImageBitmap with an HTMLVideoElement from a data URL source and a value of 0 int resizeWidth: FAIL (Chrome: PASS, Safari: PASS)
createImageBitmap with an HTMLVideoElement from a data URL source and a value of 0 in resizeHeight: FAIL (Chrome: PASS, Safari: PASS)
createImageBitmap with an HTMLVideoElement from a data URL source and a value between 0 and 1 in resizeWidth: FAIL (Chrome: PASS, Safari: PASS)
createImageBitmap with an HTMLVideoElement from a data URL source and a value between 0 and 1 in resizeHeight: FAIL (Chrome: PASS, Safari: PASS)
createImageBitmap with a bitmap HTMLImageElement source and a value of 0 int resizeWidth: FAIL (Chrome: PASS, Safari: PASS)
createImageBitmap with a bitmap HTMLImageElement source and a value of 0 in resizeHeight: FAIL (Chrome: PASS, Safari: PASS)
createImageBitmap with a bitmap HTMLImageElement source and a value between 0 and 1 in resizeWidth: FAIL (Chrome: PASS, Safari: PASS)
createImageBitmap with a bitmap HTMLImageElement source and a value between 0 and 1 in resizeHeight: FAIL (Chrome: PASS, Safari: PASS)
createImageBitmap with a vector HTMLImageElement source and a value of 0 int resizeWidth: FAIL (Chrome: FAIL, Safari: PASS)
createImageBitmap with a vector HTMLImageElement source and a value of 0 in resizeHeight: FAIL (Chrome: FAIL, Safari: PASS)
createImageBitmap with a vector HTMLImageElement source and a value between 0 and 1 in resizeWidth: FAIL (Chrome: FAIL, Safari: PASS)
createImageBitmap with a vector HTMLImageElement source and a value between 0 and 1 in resizeHeight: FAIL (Chrome: FAIL, Safari: PASS)
createImageBitmap with a bitmap SVGImageElement source and a value of 0 int resizeWidth: FAIL (Chrome: PASS, Safari: FAIL)
createImageBitmap with a bitmap SVGImageElement source and a value of 0 in resizeHeight: FAIL (Chrome: PASS, Safari: FAIL)
createImageBitmap with a bitmap SVGImageElement source and a value between 0 and 1 in resizeWidth: FAIL (Chrome: PASS, Safari: FAIL)
createImageBitmap with a bitmap SVGImageElement source and a value between 0 and 1 in resizeHeight: FAIL (Chrome: PASS, Safari: FAIL)
createImageBitmap with a vector SVGImageElement source and a value of 0 int resizeWidth: FAIL (Chrome: FAIL, Safari: FAIL)
createImageBitmap with a vector SVGImageElement source and a value of 0 in resizeHeight: FAIL (Chrome: FAIL, Safari: FAIL)
createImageBitmap with a vector SVGImageElement source and a value between 0 and 1 in resizeWidth: FAIL (Chrome: FAIL, Safari: FAIL)
createImageBitmap with a vector SVGImageElement source and a value between 0 and 1 in resizeHeight: FAIL (Chrome: FAIL, Safari: FAIL)
createImageBitmap with an OffscreenCanvas source and sw set to 0: FAIL (Chrome: PASS, Safari: FAIL)
createImageBitmap with an OffscreenCanvas source and sh set to 0: FAIL (Chrome: PASS, Safari: FAIL)
createImageBitmap with an OffscreenCanvas source and oversized (unallocatable) crop region: FAIL (Chrome: PASS, Safari: FAIL)
createImageBitmap with an OffscreenCanvas source and a value of 0 int resizeWidth: FAIL (Chrome: PASS, Safari: FAIL)
createImageBitmap with an OffscreenCanvas source and a value of 0 in resizeHeight: FAIL (Chrome: PASS, Safari: FAIL)
createImageBitmap with an OffscreenCanvas source and a value between 0 and 1 in resizeWidth: FAIL (Chrome: PASS, Safari: FAIL)
createImageBitmap with an OffscreenCanvas source and a value between 0 and 1 in resizeHeight: FAIL (Chrome: PASS, Safari: FAIL)
createImageBitmap with an ImageData source and a value of 0 int resizeWidth: FAIL (Chrome: PASS, Safari: PASS)
createImageBitmap with an ImageData source and a value of 0 in resizeHeight: FAIL (Chrome: PASS, Safari: PASS)
createImageBitmap with an ImageData source and a value between 0 and 1 in resizeWidth: FAIL (Chrome: PASS, Safari: PASS)
createImageBitmap with an ImageData source and a value between 0 and 1 in resizeHeight: FAIL (Chrome: PASS, Safari: PASS)
createImageBitmap with an ImageBitmap source and a value of 0 int resizeWidth: FAIL (Chrome: PASS, Safari: PASS)
createImageBitmap with an ImageBitmap source and a value of 0 in resizeHeight: FAIL (Chrome: PASS, Safari: PASS)
createImageBitmap with an ImageBitmap source and a value between 0 and 1 in resizeWidth: FAIL (Chrome: PASS, Safari: PASS)
createImageBitmap with an ImageBitmap source and a value between 0 and 1 in resizeHeight: FAIL (Chrome: PASS, Safari: PASS)
createImageBitmap with a Blob source and a value of 0 int resizeWidth: FAIL (Chrome: PASS, Safari: PASS)
createImageBitmap with a Blob source and a value of 0 in resizeHeight: FAIL (Chrome: PASS, Safari: PASS)
createImageBitmap with a Blob source and a value between 0 and 1 in resizeWidth: FAIL (Chrome: PASS, Safari: PASS)
createImageBitmap with a Blob source and a value between 0 and 1 in resizeHeight: FAIL (Chrome: PASS, Safari: PASS)
createImageBitmap with CanvasRenderingContext2D image source.: FAIL (Chrome: PASS, Safari: PASS)
createImageBitmap with an invalid OffscreenCanvas source.: FAIL (Chrome: PASS, Safari: FAIL)

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ee0983dbfc47 [wpt PR 27258] - Checking if resizeWidth or resizeHeight are 0 when creating Bitmap, a=testonly https://hg.mozilla.org/integration/autoland/rev/b5652ceda8a7 [wpt PR 27258] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/ee0983dbfc47
https://hg.mozilla.org/mozilla-central/rev/b5652ceda8a7

Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox86: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 86 Branch
You need to log in before you can comment on or make changes to this bug.