1687787 - Update neqo to 0.4.21

Status: RESOLVED FIXED

(Core :: Networking: HTTP, task, P2)

Comment 1

[Dragana Damjanovic [:dragana]]

Attachment: Neqo version 0.4.20

Comment 2

[Dragana Damjanovic [:dragana]]

Attachment: Adapt neqo_glue code

Disable Preferred-address for now. We need to use send_to/recv_from for it to work.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d75890964a0b
Addapt neqo_glue code r=necko-reviewers,valentin

Comment 4

[Sandor Molnar[:smolnar]]

Backed out for causing build bustages in neqo_transport::RandomConnectionIdGenerator.

Backout link: https://hg.mozilla.org/integration/autoland/rev/d09d2c00ed7a16a73c9bc0813c4b9249ab08374c

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Crunning%2Cpending%2Crunnable&revision=d75890964a0b228fdee2f1df8d4be75ab74b9c3b&selectedTaskRun=L-sIj-YkRYizEzRGG7MaEQ.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=327347780&repo=autoland&lineNumber=51047

"INFO - [webrender 0.61.0] Optimizing shader ShaderOptimizationInput { shader_name: "brush_yuv_image", config: "ALPHA_PASS,TEXTURE_RECT,YUV", gl_version: Gl }
[task 2021-01-21T09:34:50.955Z] 09:34:50 INFO - [webrender 0.61.0] Finished optimizing shader ShaderOptimizationInput { shader_name: "brush_yuv_image", config: "DEBUG_OVERDRAW,TEXTURE_2D,YUV", gl_version: Gl }
[task 2021-01-21T09:34:50.956Z] 09:34:50 ERROR - error[E0432]: unresolved import neqo_transport::RandomConnectionIdGenerator
[task 2021-01-21T09:34:50.956Z] 09:34:50 INFO - --> netwerk/socket/neqo_glue/src/lib.rs:12:52
[task 2021-01-21T09:34:50.956Z] 09:34:50 INFO - |
[task 2021-01-21T09:34:50.956Z] 09:34:50 INFO - 12 | ConnectionParameters, Error as TransportError, RandomConnectionIdGenerator, Output, QuicVersion,
[task 2021-01-21T09:34:50.956Z] 09:34:50 INFO - | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ no RandomConnectionIdGenerator in the root
[task 2021-01-21T09:34:50.956Z] 09:34:50 INFO - warning: ignoring -C extra-filename flag due to -o flag
[task 2021-01-21T09:34:50.956Z] 09:34:50 ERROR - error: aborting due to previous error; 1 warning emitted
[task 2021-01-21T09:34:50.956Z] 09:34:50 INFO - For more information about this error, try rustc --explain E0432.
[task 2021-01-21T09:34:50.956Z] 09:34:50 INFO - error: could not compile neqo_glue
[task 2021-01-21T09:34:50.956Z] 09:34:50 INFO - Caused by:
[task 2021-01-21T09:34:50.957Z] 09:34:50 INFO - process didn't exit successfully: CARGO=/builds/worker/fetches/rustc/bin/cargo CARGO_CRATE_NAME=neqo_glue CARGO_MANIFEST_DIR=/builds/worker/checkouts/gecko/netwerk/socket/neqo_glue CARGO_PKG_AUTHORS='Dragana Damjanovic <[e-mail]>' CARGO_PKG_DESCRIPTION='' CARGO_PKG_HOMEPAGE='' CARGO_PKG_LICENSE='' CARGO_PKG_LICENSE_FILE='' CARGO_PKG_NAME=neqo_glue CARGO_PKG_REPOSITORY='' CARGO_PKG_VERSION=0.1.0 CARGO_PKG_VERSION_MAJOR=0 CARGO_PKG_VERSION_MINOR=1 CARGO_PKG_VERSION_PATCH=0 CARGO_PKG_VERSION_PRE='' LD_LIBRARY_PATH='/builds/worker/workspace/obj-build/release/deps:/builds/worker/fetches/rustc/lib:/builds/worker/fetches/clang/lib:/builds/worker/fetches/clang/lib32' /builds/worker/fetches/sccache/sccache /builds/worker/fetches/rustc/bin/rustc --crate-name neqo_glue --edition=2018 netwerk/socket/neqo_glue/src/lib.rs --error-format=json --json=diagnostic-rendered-ansi,artifacts --crate-type lib --emit=dep-info,metadata,link -C opt-level=2 -C panic=abort -C embed-bitcode=no -C metadata=bbbce506594c169e -C extra-filename=-bbbce506594c169e --out-dir /builds/worker/workspace/obj-build/x86_64-unknown-linux-gnu/release/deps --target x86_64-unknown-linux-gnu -C linker=/builds/worker/checkouts/gecko/build/cargo-linker -L dependency=/builds/worker/workspace/obj-build/x86_64-unknown-linux-gnu/release/deps -L dependency=/builds/worker/workspace/obj-build/release/deps --extern log=/builds/worker/workspace/obj-build/x86_64-unknown-linux-gnu/release/deps/liblog-3e52ca7053b7956d.rmeta --extern neqo_common=/builds/worker/workspace/obj-build/x86_64-unknown-linux-gnu/release/deps/libneqo_common-c17869a340baf624.rmeta --extern neqo_crypto=/builds/worker/workspace/obj-build/x86_64-unknown-linux-gnu/release/deps/libneqo_crypto-dbaa7b2e36be4bf0.rmeta --extern neqo_http3=/builds/worker/workspace/obj-build/x86_64-unknown-linux-gnu/release/deps/libneqo_http3-cde1020fbe53c786.rmeta --extern neqo_qpack=/builds/worker/workspace/obj-build/x86_64-unknown-linux-gnu/release/deps/libneqo_qpack-520726aebf9b8711.rmeta --extern neqo_transport=/builds/worker/workspace/obj-build/x86_64-unknown-linux-gnu/release/deps/libneqo_transport-96c6c8e2ed4e87df.rmeta --extern nserror=/builds/worker/workspace/obj-build/x86_64-unknown-linux-gnu/release/deps/libnserror-cdb8ffa4fbd37532.rmeta --extern nsstring=/builds/worker/workspace/obj-build/x86_64-unknown-linux-gnu/release/deps/libnsstring-93d81053b01ae928.rmeta --extern qlog=/builds/worker/workspace/obj-build/x86_64-unknown-linux-gnu/release/deps/libqlog-3410ef62bf5ca8c1.rmeta --extern thin_vec=/builds/worker/workspace/obj-build/x86_64-unknown-linux-gnu/release/deps/libthin_vec-907a52d9c609f276.rmeta --extern xpcom=/builds/worker/workspace/obj-build/x86_64-unknown-linux-gnu/release/deps/libxpcom-ebe84eb6d9597576.rmeta -C opt-level=2 -C debuginfo=2 -C force-frame-pointers=yes -Dwarnings -Cembed-bitcode=yes -C codegen-units=1 -L native=/builds/worker/workspace/obj-build/dist/bin -L native=/builds/worker/workspace/obj-build/security/nss/lib/nss/nss_nss3 -L native=/builds/worker/workspace/obj-build/security/nss/lib/ssl/ssl_ssl3 -L native=/builds/worker/workspace/obj-build/config/external/nspr/pr (exit code: 1)
[task 2021-01-21T09:34:50.957Z] 09:34:50 INFO - warning: build failed, waiting for other jobs to finish..."

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/48f23619ddb8
Neqo version 0.4.20 r=necko-reviewers,valentin
https://hg.mozilla.org/integration/autoland/rev/5ca2c2f951ce
Addapt neqo_glue code r=necko-reviewers,valentin

Comment 6

[Sandor Molnar[:smolnar]]

Backed out for causing xpcshell failures in netwerk/test/unit/test_http3_large_post.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/3e113838f961394889c480ae8b43f1b9f2444e9d

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Crunning%2Cpending%2Crunnable&searchStr=xpc&revision=5ca2c2f951ce48da16a8a4ceeeb73219660e1538&selectedTaskRun=BgOIDQoGQZm_5UmwwMUL4A.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=327370617&repo=autoland&lineNumber=4684

"INFO - TEST-START | netwerk/test/unit/test_http3_large_post.js
[task 2021-01-21T13:10:14.125Z] 13:10:14 WARNING - TEST-UNEXPECTED-FAIL | netwerk/test/unit/test_http3_large_post.js | xpcshell return code: 0
[task 2021-01-21T13:10:14.125Z] 13:10:14 INFO - TEST-INFO took 30246ms
[task 2021-01-21T13:10:14.125Z] 13:10:14 INFO - >>>>>>>
[task 2021-01-21T13:10:14.125Z] 13:10:14 INFO - (xpcshell/head.js) | test MAIN run_test pending (1)
[task 2021-01-21T13:10:14.125Z] 13:10:14 INFO - (xpcshell/head.js) | test run_next_test 0 pending (2)
[task 2021-01-21T13:10:14.125Z] 13:10:14 INFO - (xpcshell/head.js) | test MAIN run_test finished (2)
[task 2021-01-21T13:10:14.125Z] 13:10:14 INFO - running event loop
[task 2021-01-21T13:10:14.125Z] 13:10:14 INFO - netwerk/test/unit/test_http3_large_post.js | Starting setup
[task 2021-01-21T13:10:14.125Z] 13:10:14 INFO - (xpcshell/head.js) | test setup pending (2)
[task 2021-01-21T13:10:14.125Z] 13:10:14 INFO - TEST-PASS | netwerk/test/unit/test_http3_large_post.js | setup - [setup : 10] "35292" != null
[task 2021-01-21T13:10:14.125Z] 13:10:14 INFO - TEST-PASS | netwerk/test/unit/test_http3_large_post.js | setup - [setup : 10] "35292" != ""
[task 2021-01-21T13:10:14.125Z] 13:10:14 INFO - (xpcshell/head.js) | test run_next_test 0 finished (2)
[task 2021-01-21T13:10:14.125Z] 13:10:14 INFO - PID 32699 | routed is NA
[task 2021-01-21T13:10:14.125Z] 13:10:14 INFO - PID 32699 | try again to get alt svc mapping
[task 2021-01-21T13:10:14.125Z] 13:10:14 INFO - PID 32699 | results=false
[task 2021-01-21T13:10:14.125Z] 13:10:14 INFO - "CONSOLE_MESSAGE: (info) Alternate Service Mapping found: https://foo.example.com:-1 to https://foo.example.com:35292"
[task 2021-01-21T13:10:14.125Z] 13:10:14 INFO - PID 32699 | routed is foo.example.com:35292
[task 2021-01-21T13:10:14.125Z] 13:10:14 INFO - TEST-PASS | netwerk/test/unit/test_http3_large_post.js | setup - [setup : 1] "h3" == "h3"
[task 2021-01-21T13:10:14.125Z] 13:10:14 INFO - PID 32699 | results=true
[task 2021-01-21T13:10:14.125Z] 13:10:14 INFO - (xpcshell/head.js) | test run_next_test 1 pending (2)
[task 2021-01-21T13:10:14.125Z] 13:10:14 INFO - (xpcshell/head.js) | test setup finished (2)
[task 2021-01-21T13:10:14.125Z] 13:10:14 INFO - netwerk/test/unit/test_http3_large_post.js | Starting test_large_post
[task 2021-01-21T13:10:14.125Z] 13:10:14 INFO - (xpcshell/head.js) | test test_large_post pending (2)
[task 2021-01-21T13:10:14.125Z] 13:10:14 INFO - (xpcshell/head.js) | test run_next_test 1 finished (2)
[task 2021-01-21T13:10:14.126Z] 13:10:14 INFO - "CONSOLE_MESSAGE: (info) Alternate Service Mapping found: https://foo.example.com:-1 to https://foo.example.com:35292"
[task 2021-01-21T13:10:14.126Z] 13:10:14 WARNING - TEST-UNEXPECTED-FAIL | netwerk/test/unit/test_http3_large_post.js | test_large_post - [test_large_post : 20] 2147500036 == 0
[task 2021-01-21T13:10:14.126Z] 13:10:14 INFO - /builds/worker/workspace/build/tests/xpcshell/tests/netwerk/test/unit/test_http3_large_post.js:testOnStartRequest:20
[task 2021-01-21T13:10:14.126Z] 13:10:14 INFO - /builds/worker/workspace/build/tests/xpcshell/head.js:_do_main:239
[task 2021-01-21T13:10:14.126Z] 13:10:14 INFO - /builds/worker/workspace/build/tests/xpcshell/head.js:_execute_test:567
[task 2021-01-21T13:10:14.126Z] 13:10:14 INFO - -e:null:1
[task 2021-01-21T13:10:14.126Z] 13:10:14 INFO - exiting test
[task 2021-01-21T13:10:14.128Z] 13:10:14 INFO - PID 32699 | JavaScript error: /builds/worker/workspace/build/tests/xpcshell/head.js, line 827: NS_ERROR_ABORT:
[task 2021-01-21T13:10:14.128Z] 13:10:14 WARNING - TEST-UNEXPECTED-FAIL | netwerk/test/unit/test_http3_large_post.js | test_large_post - [test_large_post : 39] "" == "h3"
[task 2021-01-21T13:10:14.128Z] 13:10:14 INFO - /builds/worker/workspace/build/tests/xpcshell/tests/netwerk/test/unit/test_http3_large_post.js:testOnStopRequest:39
[task 2021-01-21T13:10:14.128Z] 13:10:14 INFO - /builds/worker/workspace/build/tests/xpcshell/head.js:_do_main:239
[task 2021-01-21T13:10:14.129Z] 13:10:14 INFO - /builds/worker/workspace/build/tests/xpcshell/head.js:_execute_test:567
[task 2021-01-21T13:10:14.129Z] 13:10:14 INFO - -e:null:1
[task 2021-01-21T13:10:14.129Z] 13:10:14 INFO - exiting test"

Comment 7

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/mozilla-central/rev/c3bf87f972d5
Backed out 2 changesets for causing xpcshell failures in netwerk/test/unit/test_http3_large_post. CLOSED TREE

Comment 8

[Dragana Damjanovic [:dragana]]

Attachment: Neqo Version 0.4.21

Comment 9

[Dragana Damjanovic [:dragana]]

Attachment: ClientRequestStream implements Hash now, we should use it instead of a hack we have now.

Until now using debug string of request use to work, because the string has remained constant. With last changes in neqo it is not constant anymore. Therefore, we made ClientRequestStream public and made it implement Hash.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0c8be05e55f8
Neqo Version 0.4.21 r=necko-reviewers,valentin
https://hg.mozilla.org/integration/autoland/rev/67c7654a4ff4
Adapt neqo_glue code r=necko-reviewers,valentin
https://hg.mozilla.org/integration/autoland/rev/8dd50bba4b1b
ClientRequestStream implements Hash now, we should use it instead of a hack we have now. r=necko-reviewers,valentin

Comment 11

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/0c8be05e55f8
https://hg.mozilla.org/mozilla-central/rev/67c7654a4ff4
https://hg.mozilla.org/mozilla-central/rev/8dd50bba4b1b