1687893 - New tab-modal JS Alert doesn't give attention to different tab when attempting to close Firefox

Status: VERIFIED FIXED

(Firefox :: Untriaged, defect)

Description

[lolrepeatlol]

Attachment: Demonstration of bug

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:86.0) Gecko/20100101 Firefox/86.0

Steps to reproduce:

I tried to close Firefox Nightly while listening to Apple Music.

Actual results:

Apple Music tried to ask whether I really wanted to close Firefox, but I didn't know because Firefox didn't switch the tab to Apple Music.

Expected results:

Apple Music should get attention when trying to close Firefox.

I believe the bug that caused this bug was https://bugzilla.mozilla.org/show_bug.cgi?id=1680637.

Comment 1

[:Gijs (he/him)]

Isn't this a dupe of bug 1686316? Micah, I thought the first patch there (that has already landed on central a few days ago) would have fixed this case - maybe I'm misunderstanding something?

Comment 2

[Micah [:mtigley] (she/her)]

(In reply to :Gijs (he/him) from comment #1)

Isn't this a dupe of bug 1686316? Micah, I thought the first patch there (that has already landed on central a few days ago) would have fixed this case - maybe I'm misunderstanding something?

I thought so too. The patch in bug 1686316 should be sending the proper event detail information for the new modal UI now. I took a closer look and it looks like the inPermitUnload value is undefined with the new prompts: https://searchfox.org/mozilla-central/source/browser/base/content/tabbrowser.js#5414. With the old one, this value is set to true so that whole block is skipped over to select the tab. So I think there's still information we're not passing to openPromptWithTabDialogBox through its args.

Comment 3

[Micah [:mtigley] (she/her)]

(In reply to Micah Tigley [:mtigley] from comment #2)

I took a closer look and it looks like the inPermitUnload value is undefined with the new prompts

...that's because we're assigning args.inPermitUnload to wasPermitUnload: https://searchfox.org/mozilla-central/source/browser/actors/PromptParent.jsm#276

Comment 4

[Micah [:mtigley] (she/her)]

Attachment: Bug 1687893 - Make opening/closing eventDetail consistent between TabModalPrompt and TabDialogBox content prompts. r?Gijs

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5fef480fe803
Make opening/closing eventDetail consistent between TabModalPrompt and TabDialogBox content prompts. r=Gijs

Comment 6

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/5fef480fe803

Comment 7

[Rares Doghi, Desktop QA]

This issue is Verified as fixed in our Release 86.0.1 as well as our latest Release, Beta and Nightly versions of Firefox.