Closed Bug 1687948 Opened 5 years ago Closed 5 years ago

Add a test for :screenshot --fullpage with a fixed element while the page is scrolled down

Categories

(DevTools :: Console, task)

task

Tracking

(firefox87 fixed)

RESOLVED FIXED
87 Branch
Tracking Status
firefox87 --- fixed

People

(Reporter: nchevobbe, Assigned: nchevobbe)

References

Details

Attachments

(2 files)

The issue is described in https://bugzilla.mozilla.org/show_bug.cgi?id=961832#c0 , but no test was added when fixing it.

A fix was made in Bug 961832 to ensure fixed elements would be rendered at the
right position in the screenshot when the page was scrolled down.
Unfortunately there wasn't any test associated, so this patch adds one.

The test does fails if we revert the changes made in Bug 961832.

We're going to use some of the function provided by this
helper in console tests, so it feels better to move the
content of the file in shared-head so all panels can benefit
from it.

Attachment #9198419 - Attachment description: Bug 1687948 - Add test for fullpage screenshot of website with fixed element. r=jdescottes. → Bug 1687948 - [devtools] Add test for fullpage screenshot of website with fixed element. r=jdescottes.
Pushed by nchevobbe@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/8f7cc8890f9c [devtools] Move helper_screenshot_node.js content to shared-head. r=jdescottes. https://hg.mozilla.org/integration/autoland/rev/ec2c8f28b283 [devtools] Add test for fullpage screenshot of website with fixed element. r=jdescottes.
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → 87 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: