1687970 - Search bar focus ring does not exist when newNewtabExperience is enabled and search handoff enabled

Status: VERIFIED FIXED

(Firefox :: New Tab Page, defect, P1)

Description

[:prathiksha]

Spec: https://www.figma.com/file/hGOaTi5ufs2Ese6agbUN4G/New-New-Tab?node-id=1227%3A12445

Comment 2

[:prathiksha]

Attachment: Bug 1687970 - Search bar focus ring should appear on click.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7d4655478846
Search bar focus ring should appear on click. r=ewright

Comment 4

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/7d4655478846

Comment 5

[:prathiksha]

Comment on attachment 9199547 [details]
Bug 1687970 - Search bar focus ring should appear on click.

Beta/Release Uplift Approval Request

• User impact if declined: A small portion of users enrolled in our experiment will not be able to focus the search bar on click
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: 1. Set browser.newtabpage.activity-stream.newNewtabExperience.enabled to true.

2. Click on the search bar. You should see a border and a box shadow as shown under Components -> Search bar here0.

• List of other uplifts needed: No
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Small style change only seen by a small number of users enrolled in an experiment
• String changes made/needed: None

Comment 6

[Pascal Chevrel:pascalc]

Prathiksha, if there is another uplift needed, could you please request it in bug 1685490? I see that this bug was reopened, it that actually ready for uplifting? thanks

Comment 7

[:prathiksha]

(In reply to Pascal Chevrel:pascalc from comment #6)

Prathiksha, if there is another uplift needed, could you please request it in bug 1685490? I see that this bug was reopened, it that actually ready for uplifting? thanks

Yes, Pascal, we will request the uplift for bug 1685490 in it's own bug. This bug is not re-opened and it's ready for an uplift.

I have updated my uplift request to exclude bug 1685490.

Comment 8

[Pascal Chevrel:pascalc]

Comment on attachment 9199547 [details]
Bug 1687970 - Search bar focus ring should appear on click.

Approved for 86 beta 4, thanks.

Comment 9

[Julien Cristau [:jcristau] (back August 18)]

https://hg.mozilla.org/releases/mozilla-beta/rev/3d4adeeb2e8a

Comment 10

[Marius Coman [:mcoman], Ecosystem QA]

I have verified that this issue is no longer reproducible with the latest Firefox Beta (86.0b4 Build ID - 20210131185630) and the latest Firefox Nightly (87.0a1 Build ID - 20210131211743) installed on Windows 10 x64, Windows 7 x64, and Windows 8.1 x32. Now, I can confirm that the in-content "Search Bar" focus ring is correctly displayed when the search bar is focused.