1687999 - Two focuses are wrongly displayed on the in-content "Search Bar" if the search handoff is disabled

Status: VERIFIED FIXED

(Firefox :: New Tab Page, defect, P1)

Description

[Marius Coman [:mcoman], Ecosystem QA]

Attachment: ss of the issue.png

[Affected versions]:

• Firefox Beta 85.0 RC1 - Build ID: 20210118153634
• Firefox Nightly 86.0a1 - Build ID: 20210121094402

[Affected Platforms]:

• Windows 10 x64
• Mac 10.15
• Linux Mint 20

[Prerequisites]:

• Have a Firefox profile with the following prefs in the "about:config" page:
  • "browser.newtabpage.activity-stream.newNewtabExperience.enabled" pref set to "true"
  • "browser.newtabpage.activity-stream.improvesearch.handoffToAwesomebar" set to "false"

[Steps to reproduce]:

1. Open the browser with the profile from prerequisites and open a "New Tab".
2. Click inside the in-content "Search Bar" and observe the behavior.

[Expected result]:

• The in-content "Search Bar" is focused according to the specifications.

[Actual result]:

• Two focuses are displayed on the in-content "Search Bar".

[Additional Notes]:

• This issue is not reproducible if the "browser.newtabpage.activity-stream.improvesearch.handoffToAwesomebar" pref is set to "true".
• Attached a screenshot of the issue.

Comment 1

[:prathiksha]

Marking this as P1 because it affects release users in our experiment.

Comment 2

[:prathiksha]

Attachment: Bug 1687999 - Remove old outline from the old search bar focus effect when newNewtabExperience is enabled and searchHandoff is disabled. r?ewright

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/813715c81c40
Remove old outline from the old search bar focus effect when newNewtabExperience is enabled and searchHandoff is disabled. r=ewright

Comment 4

[:prathiksha]

Comment on attachment 9200382 [details]
Bug 1687999 - Remove old outline from the old search bar focus effect when newNewtabExperience is enabled and searchHandoff is disabled. r?ewright

Beta/Release Uplift Approval Request

• User impact if declined: Users in an experiment will see two search bar focus effects
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Small style changes behind a pref
• String changes made/needed: None

Comment 5

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/813715c81c40

Comment 6

[Marius Coman [:mcoman], Ecosystem QA]

I have verified that this issue is no longer reproducible with the latest Firefox Nightly (87.0a1 Build ID - 20210204093834) installed on Windows 10 x64, macOS 10.15.7, and Linux Mint 20 x64. Now, I can confirm that the only one focus is displayed on the in-content "Search Bar" if the search handoff is disabled.

Comment 7

[Pascal Chevrel:pascalc]

Comment on attachment 9200382 [details]
Bug 1687999 - Remove old outline from the old search bar focus effect when newNewtabExperience is enabled and searchHandoff is disabled. r?ewright

Approved for 86 beta 6, thanks.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/49b06045e006

Comment 9

[Marius Coman [:mcoman], Ecosystem QA]

I have verified that this issue is no longer reproducible with the latest Firefox Beta (86.0b6 Build ID - 20210204185843) installed on Windows 10 x64, macOS 10.15.7, and Linux Mint 20 x64. Now, I can confirm that the only one focus is displayed on the in-content "Search Bar" if the search handoff is disabled.