1688009 - Statistics pane pie chart is interactive but is not accessible.

Status: RESOLVED FIXED

(DevTools :: Netmonitor, defect, P3)

Description

[Yura Zenevich [:yzen] (please use "needinfo")]

This was discovered with bug 1687789. This test is now marked as fail-if = a11y_checks. You can run the test with a11y checks locally with --enable-a11y-checks (or on linux 64 opt in integration).

At the moment, the pie chart is only usable with mouse. However it should also be made accessible: keyboard navigation, labelling and semantics.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The severity field for this bug is set to S3. However, the accessibility severity is higher, [access-s2].
:Honza, could you consider increasing the severity?

For more information, please visit auto_nag documentation.

Comment 2

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1688009 - [devtools] Make Netmonitor Performance Analysis panel more accessible. r=bomsy.

The data were presented in a table-like fashion, but weren't using accessible
elements for this, making it impossible to understand when using a screenreader.
We switch to use <table> and proper internal elements.

The pie-chart wasn't accessible at all, so we create groups and adds proper role
to items, and wrap slices in an interactive element so they can be interacted with
through the keyboard. This allow us to remove the fail-if annotation on the browser_net_statistics-02.js test.

Some items were missing, both in the table and the pie-chart, to make the panel
cleaner. The downside is that it was hard for a keyboard-only user to understand
the whole thing. So now, we do put all the data in the DOM, and visually hide
the items that wouldn't look great on screen.

Finally, we take this opportuniy to cleanup the implementation a bit, removing
unnecessary CSS and properties.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/49c4483a1219
[devtools] Make Netmonitor Performance Analysis panel more accessible. r=bomsy.

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/49c4483a1219