1688055 - Refactor LexicalEnvironmentObject into several subclasses

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P3)

Description

[Jason Orendorff [:jorendorff]]

In anticipation of adding a ClassBodyEnvironmentObject class to the hierarchy, I'd like LexicalEnvironmentObject not to be so large and weird.

Comment 1

[Jason Orendorff [:jorendorff]]

Attachment: Bug 1688055 - Part 1: Factor out a GlobalLexicalEnvironmentObject subclass from LexicalEnvironmentObject. r=mgaudet

Comment 2

[Jason Orendorff [:jorendorff]]

Attachment: Bug 1688055 - Part 2: Factor out a NonSyntacticLexicalEnvironmentObject subclass from LexicalEnvironmentObject. r=mgaudet

Depends on D106518

Comment 3

[Jason Orendorff [:jorendorff]]

Attachment: Bug 1688055 - Part 3: Factor out an ExtensibleLexicalEnvironmentObject subclass from LexicalEnvironmentObject. r=mgaudet

Depends on D106519

Comment 4

[Jason Orendorff [:jorendorff]]

Attachment: Bug 1688055 - Part 4: Use existing NamedLambdaObject subclass rather than LexicalEnvironmentObject where appropriate. r=mgaudet

Depends on D106520

Comment 5

[Jason Orendorff [:jorendorff]]

Attachment: Bug 1688055 - Part 5: Factor out BlockLexicalEnvironmentObject subclass from LexicalEnvironmentObject. r=mgaudet

Depends on D106521

Comment 6

[Jason Orendorff [:jorendorff]]

Attachment: Bug 1688055 - Part 6: Reorder definitions in EnvironmentObject.cpp to match declaration order. r=mgaudet

Depends on D106522

Comment 7

[Jason Orendorff [:jorendorff]]

Attachment: Bug 1688055 - Part 7: Adjust a few comments about environments. r=mgaudet

Depends on D106523

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3866de326a0b
Part 1: Factor out a GlobalLexicalEnvironmentObject subclass from LexicalEnvironmentObject. r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/c42a776a1a13
Part 2: Factor out a NonSyntacticLexicalEnvironmentObject subclass from LexicalEnvironmentObject. r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/fc50fb18ae12
Part 3: Factor out an ExtensibleLexicalEnvironmentObject subclass from LexicalEnvironmentObject. r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/ca92674badfb
Part 4: Use existing NamedLambdaObject subclass rather than LexicalEnvironmentObject where appropriate. r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/78cb751e99d7
Part 5: Factor out BlockLexicalEnvironmentObject subclass from LexicalEnvironmentObject. r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/5d2ed51e4959
Part 6: Reorder definitions in EnvironmentObject.cpp to match declaration order. r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/f2ecfa12e3d9
Part 7: Adjust a few comments about environments. r=mgaudet

Comment 9

[Atila Butkovits]

Backed out for Spidermonkey failures.

Backout link: https://hg.mozilla.org/integration/autoland/rev/bad7f5a4b1f10e1c59ce3e9381e495d8b8dab2ea

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&revision=f2ecfa12e3d90f3475df82f7cf05dddf21405997&searchStr=linux%2Cx64%2Cdebug%2Cspidermonkey%2Cbuilds%2Cspidermonkey-sm-nonunified-linux64%2Fdebug%2Cnu

Failure log: https://treeherder.mozilla.org/logviewer?job_id=331987367&repo=autoland&lineNumber=3821

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bf6c77c8a0fe
Part 1: Factor out a GlobalLexicalEnvironmentObject subclass from LexicalEnvironmentObject. r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/afd56f0fae1b
Part 2: Factor out a NonSyntacticLexicalEnvironmentObject subclass from LexicalEnvironmentObject. r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/744f39b7bb3a
Part 3: Factor out an ExtensibleLexicalEnvironmentObject subclass from LexicalEnvironmentObject. r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/e0ddf096cde9
Part 4: Use existing NamedLambdaObject subclass rather than LexicalEnvironmentObject where appropriate. r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/6e6d301b0066
Part 5: Factor out BlockLexicalEnvironmentObject subclass from LexicalEnvironmentObject. r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/954d6682b6c5
Part 6: Reorder definitions in EnvironmentObject.cpp to match declaration order. r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/d2fec58f3f7d
Part 7: Adjust a few comments about environments. r=mgaudet

Comment 11

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/bf6c77c8a0fe
https://hg.mozilla.org/mozilla-central/rev/afd56f0fae1b
https://hg.mozilla.org/mozilla-central/rev/744f39b7bb3a
https://hg.mozilla.org/mozilla-central/rev/e0ddf096cde9
https://hg.mozilla.org/mozilla-central/rev/6e6d301b0066
https://hg.mozilla.org/mozilla-central/rev/954d6682b6c5
https://hg.mozilla.org/mozilla-central/rev/d2fec58f3f7d