1688063 - Enable prompt counts for the default browser check modal

Status: VERIFIED FIXED

(Firefox :: Messaging System, enhancement, P1)

Description

[Andrei Oprea [:andreio]]

There is telemetry in place to count the number of times the default browser modal is shown but this is not reported in the release channel. For the purposes of the experiment looking into replacing this modal with an infobar (see Blocks bug) this information is needed by DS to evaluate the results and compare.

Comment 1

[Andrei Oprea [:andreio]]

Attachment: Bug 1688063 - Enable prompt counts for the default browser check modal

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/be5a8ab656ca
Enable prompt counts for the default browser check modal r=Gijs

Comment 3

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/be5a8ab656ca

Comment 4

[Andrei Oprea [:andreio]]

Comment on attachment 9198614 [details]
Bug 1688063 - Enable prompt counts for the default browser check modal

Beta/Release Uplift Approval Request

• User impact if declined: No user impact. Telemetry required for experiment in 86.
  https://mana.mozilla.org/wiki/pages/viewpage.action?pageId=130918595
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Telemetry only patch, code is not new. The change enabled data collection in all release channels.
• String changes made/needed:

Comment 5

[Marius Coman [:mcoman], Ecosystem QA]

I have verified this enhancement and I can confirm that the number of times the default browser modal is shown are correctly counted by the browser.shell.defaultBrowserCheckCount pref.

Verified using the latest Firefox Nightly (87.0a1 Build ID - 20210201094443) installed on Windows 10 x64, Mac 10.15.7, and Linux Mint 20 x64.

Comment 6

[Pascal Chevrel:pascalc (PTO until April 26)]

Comment on attachment 9198614 [details]
Bug 1688063 - Enable prompt counts for the default browser check modal

Approved for 86 beta 5, thanks.

Comment 7

[Julien Cristau [:jcristau]]

https://hg.mozilla.org/releases/mozilla-beta/rev/03d57f169560

Comment 8

[Marius Coman [:mcoman], Ecosystem QA]

I have verified this enhancement and I can confirm that the number of times the default browser modal is shown are correctly counted by the browser.shell.defaultBrowserCheckCount pref.

Verified using the latest Firefox Beta (86.0b5 Build ID - 20210202185823) installed on Windows 10 x64, Mac 10.15.7, and Linux Mint 20 x64.