1688189 - Show Firefox logo when pocket is enabled if "logowordmark.alwaysAvailable" is set to true

Status: VERIFIED FIXED

(Firefox :: New Tab Page, task, P1)

Description

[:prathiksha]

Spec: https://www.figma.com/file/hGOaTi5ufs2Ese6agbUN4G/New-New-Tab?node-id=985%3A9859

Comment 1

[:prathiksha]

Attachment: Bug 1688189 - Show Firefox logo when pocket is enabled if logowordmark.alwaysAvailable is set to true.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6d6e912c1468
Show Firefox logo when pocket is enabled if logowordmark.alwaysAvailable is set to true. r=ewright

Comment 3

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/6d6e912c1468

Comment 4

[:prathiksha]

Comment on attachment 9198699 [details]
Bug 1688189 - Show Firefox logo when pocket is enabled if logowordmark.alwaysAvailable is set to true.

Beta/Release Uplift Approval Request

• User impact if declined: No effect on users. We cannot perform our experiment as desired on a small group of users in Firefox 86.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Steps to reproduce:

1. Set browser.newtabpage.activity-stream.newNewtabExperience.enabled to true.

2. Check that browser.newtabpage.activity-stream.logowordmark.alwaysVisible is set to false by default and verify that the logo and wordmark are visible on the newtab page only when all sections except search are hidden.

3. Set browser.newtabpage.activity-stream.logowordmark.alwaysVisible to true and verify that the logo and wordmark are visible on the newtab page at all times even if Pocket and Highlights are visible.

• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): It shouldn't affect most users in release. This change only affects our experiment and it is covered by automated tests.
• String changes made/needed: None

Comment 5

[Pascal Chevrel:pascalc]

Comment on attachment 9198699 [details]
Bug 1688189 - Show Firefox logo when pocket is enabled if logowordmark.alwaysAvailable is set to true.

Approved for beta 2

Comment 6

[Julien Cristau [:jcristau] (back August 18)]

https://hg.mozilla.org/releases/mozilla-beta/rev/a3f36be92ea5

Comment 7

[Ciprian Muresan [:cmuresan], Formerly of Ecosystem QA - please needinfo @mcoman for things regarding the team]

I have verified that while the browser.newtabpage.activity-stream.logowordmark.alwaysVisible is set to false the logo is only displayed when ALL sections (except Snippets) are disabled. And have verified that when it is set to true the logo will always be displayed regardless of which sections are enabled/disabled.

The above verification was performed on the latest Firefox Nightly 87.0a1 (BuildID 20210127093943) and the latest Beta 86.0b2 (BuildID 20210126185730) using Windows 10, macOS 10.15, LinuxMX 4.19.