1688198 - Symbol.toStringTag is incorrectly defined on the global object, rather than on its prototype

Status: RESOLVED FIXED

(Core :: DOM: Bindings (WebIDL), defect, P3)

Description

[ExE Boss]

Attachment: testcase.html

This was discovered while working on wpt#27239.

---

The Symbol.toStringTag property is always supposed to be on the interface prototype object, because the class string is specified for the prototype, regardless of whether the interface is a global object.

Comment 1

[Peter Van der Beken [:peterv]]

Attachment: Bug 1688198 - Symbol.toStringTag is incorrectly defined on the global object, rather than on its prototype. r?edgar.

For [Global] WebIDL interfaces, properties from the property array are installed
on the object itself, instead of on the prototype. To fix the bug I changed how
we install the @@toStringTag property, instead of adding it in the property
array of every interface we'll now instead install the property directly in
CreateInterfaceObject, which is also a codesize win. This does mean that we need
to look up the value dynamically in XrayResolveOwnProperty (we can't resolve it
from the property array anymore), but luckily we can use
NamesOfInterfacesWithProtos for that.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3cc5c27ee349
Symbol.toStringTag is incorrectly defined on the global object, rather than on its prototype. r=edgar.

Comment 3

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/3cc5c27ee349