1688239 - Move mozilla::net::ResolverMode into nsIDNSService and use it consistently

Status: RESOLVED FIXED

(Core :: Networking: DNS, task, P2)

Description

[(inactive) Nihanth Subramanya [:nhnt11]]

For some reason, the TRR service declares mMode as a uint32_t instead of nsIRequest::TRRMode or the wrapper nsHostResolver:ResolverMode (which is used fairly consistently elsewhere).

It'd be nice to explicitly type mMode for consistency. We are even setting the value from the ResolverMode constants already.

Comment 1

[(inactive) Nihanth Subramanya [:nhnt11]]

So... I took a poke at this and it turns out that TRRServiceBase.h ends up getting included when building UnifiedProtocols*.cpp due to the TRR service now living in the socket process and the way the IPC is implemented. This works because TRRServiceBase.h is exported into mozilla/net in netwerk/dns/moz.build. But we can't include nsHostResolver.h to get access to the ResolverMode name without also exporting nsHostResolver.h and everything that it includes into mozilla/net as well.

I think the right solution here would be to move the enum declaration into somewhere like nsIDNSService.idl (since GetCurrentTRRMode needs it) and use it from there.

Comment 2

[(inactive) Nihanth Subramanya [:nhnt11]]

Attachment: Bug 1688239 - Move mozilla::net::ResolverMode into nsIDNSService and use it consistently. r=#necko

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/048813c76685
Move mozilla::net::ResolverMode into nsIDNSService and use it consistently. r=necko-reviewers,valentin

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/048813c76685