1688249 - Remove the number of the lambda expression from the signature

Status: RESOLVED FIXED

(Socorro :: Signature, task, P2)

Description

[Andrew McCreight [:mccr8]]

As seen in bug 1592336, the stack frames for C++ lambdas seems to include a more-or-less arbitrary integer, causing signatures to vary by build. It would be nice if these integers could be removed.

For example, presumably it would be better if these signatures were the same:
[@ mozilla::dom::indexedDB::(anonymous namespace)::QuotaClient::ShutdownWorkThreads::$_33::__invoke ]
[@ mozilla::dom::indexedDB::(anonymous namespace)::QuotaClient::ShutdownWorkThreads::$_36::__invoke ]
[@ mozilla::dom::indexedDB::(anonymous namespace)::QuotaClient::ShutdownWorkThreads::$_3::__invoke ]

Comment 1

[Will Kahn-Greene [:willkg] ET needinfo? me]

Hrm... I'm not sure how to do this offhand. I'll have to look into it.

Does "It would be nice" imply that it's a nice-to-have (implement it in the next month) and not an urgent must-have (implement it this week)?

Comment 2

[Andrew McCreight [:mccr8]]

Is there any kind of rewriting that happens on signatures? It feels like you could replace "::$_\d+::" with "::$::" or something.

Yeah, I don't think it is urgent. Bug 1592336 is the first place I remember seeing it, and it seems like it is at most a minor hassle there.

Comment 3

[Will Kahn-Greene [:willkg] ET needinfo? me]

Attachment: pr 5660: bug #1688249: remove lambda number from signature

Comment 4

[Will Kahn-Greene [:willkg] ET needinfo? me]

willkg merged PR #5660: "bug #1688249: remove lambda number from signature" in 5b7b9e8.

Andrew: That regex helped a lot--you were right on! Thank you!

Comment 5

[Andrew McCreight [:mccr8]]

Great! Thanks for working on this.

Comment 6

[Will Kahn-Greene [:willkg] ET needinfo? me]

This was deployed just now in bug #1690378. Marking as FIXED.

Comment 7

[Will Kahn-Greene [:willkg] ET needinfo? me]

Andrew: Do you want me to reprocess these crash reports?

Comment 8

[Andrew McCreight [:mccr8]]

The volume looks pretty low, but maybe Jens would be interested in it.

Comment 9

[Will Kahn-Greene [:willkg] ET needinfo? me]

I misread comment #8 and went ahead and reprocessed 20,000 crash reports over the last 6 months that had __invoke in the signature. It was a pretty lazy search, so it picked up a bunch of other crash reports that aren't relevant which is probably fine.

Comment 10

[Jens Stutte [:jstutte]]

Thanks!