1688394 - Remove ScriptStencil::HasMemberInitializers flag

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P2)

Description

[Ted Campbell [:tcampbell]]

As a follow-up to Bug 1688327, we should consider replacing the ScriptStencil::HasMemberInitializers flag with an ImmutableScriptFlag. This makes sense now that the member initializer data is part of initial parse.

Additionally, we would be able to relax the member-initializer conditions from all class-constructors to simply ones that need it. This would solve Bug 1622371 regression.

Comment 1

[Ted Campbell [:tcampbell]]

Attachment: Bug 1688394 - Remove ScriptStencil::HasMemberInitializers. r?arai!

Replace this with ImmutableScriptFlagsEnum::UseMemberInitializers since it
must have a consistent value across initial and delazify parses.

Comment 2

[Ted Campbell [:tcampbell]]

Attachment: Bug 1688394 - Only set UseMemberInitializers if there are any. r?arai!

If a scripted class constructor has zero member initializers associated with
it, we now avoid storing and updating MemberInitializers data for it. This
avoids the need allocate PrivateScriptData for lazy class constructors that
have no fields or inner functions which saves memory overhead.

Depends on D102840

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1448619c7edd
Remove ScriptStencil::HasMemberInitializers. r=arai
https://hg.mozilla.org/integration/autoland/rev/d16ebdaed14f
Only set UseMemberInitializers if there are any. r=arai

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/1448619c7edd
https://hg.mozilla.org/mozilla-central/rev/d16ebdaed14f