1688509 - ResponsiveImageSelector.cpp: do not use 'else' after 'break'

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task, P3)

Description

[Sylvestre Ledru [:Sylvestre]]

+++ This bug was initially created as a clone of Bug #1688503 +++

Filling as a good first bug to learn workflows.

do not use 'else' after 'break':
https://searchfox.org/mozilla-central/source/dom/base/ResponsiveImageSelector.cpp#615-616

As the change is trivial, it is just to learn how to contribute to Firefox.

Found by http://clang.llvm.org/extra/clang-tidy/checks/readability-else-after-return.html

Tutorial to contribute:
https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html
https://firefox-source-docs.mozilla.org/contributing/stack_quickref.html

Please don't ask for the bug to be assigned. It will be automatically assigned to the first patch.

Comment 1

[Abhishek Sharma[:mick]]

Can I work on this bug?

Comment 2

[Abhishek Sharma[:mick]]

Attachment: "Bug 1688509 - ResponsiveImageSelector.cpp: do not use 'else' after 'break' :Sylvestre"

Depends on D103345

Comment 3

[Abhishek Sharma[:mick]]

Attachment: "Bug 1688509 - ResponsiveImageSelector.cpp: do not use 'else' after 'break' ":Sylvestre"

Remove the else if statement

Depends on D103345

Comment 4

[Sylvestre Ledru [:Sylvestre]]

Abhishek, as I was saying in the review, I am unassigning these bugs from you.
You need to compile and test your changes and you haven't despite asking several times.

Comment 5

[Abhishek Sharma[:mick]]

Attachment: "Bug 1688509 - ResponsiveImageSelector.cpp: do not use 'else' after 'break' ":Sylvestre""

Depends on D103866

Comment 6

[james]

Hey Sylvestre,
I am new to bug fixing may I know what is the status on this bug, if possible I would like to take this up

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

This good-first-bug hasn't had any activity for 2 months, it is automatically unassigned.
For more information, please visit auto_nag documentation.

Comment 8

[Jane Kotovich (:janey)]

Hi Sylvestre Ledru [:Sylvestre],

My name is Jane, I'm from Outreachy. I would love to work on this bug which is obviously easy to fix because everything is clarified already :)
My q is regarding tests - when I am running them locally, do I do: "mach test devtools/dom/base/ResponsiveImageSelector.cpp --headless" ?
a little bit lost with the test options. Would extremely appreciate nay clarification! Kind regards!

Comment 9

[Jane Kotovich (:janey)]

Attachment: Bug 1688509 - [dom] Remove Else after Break. r=sylvestre

Depends on D111770

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b952cb5a8f92
[dom] Remove Else after Break. r=sylvestre

Comment 11

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/b952cb5a8f92