1688511 - StartupCacheUtils.cpp: do not use 'else' after 'return'

Status: RESOLVED FIXED

(Toolkit :: Startup and Profile System, task)

Description

[Sylvestre Ledru [:Sylvestre]]

+++ This bug was initially created as a clone of Bug #1688504 +++

Filling as a good first bug to learn workflows.

do not use 'else' after 'return':
https://searchfox.org/mozilla-central/rev/7431701c98da9218fda314a54efa1a3093760f65/startupcache/StartupCacheUtils.cpp#155-156

As the change is trivial, it is just to learn how to contribute to Firefox.

Found by http://clang.llvm.org/extra/clang-tidy/checks/readability-else-after-return.html

Tutorial to contribute:
https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html
https://firefox-source-docs.mozilla.org/contributing/stack_quickref.html

Please don't ask for the bug to be assigned. It will be automatically assigned to the first patch.

Comment 1

[Abhishek Sharma[:mick]]

Hi Sylvestre,
Can I work on this bug?

Abhishek

Comment 2

[Sylvestre Ledru [:Sylvestre]]

Sure (please read the whole message ;)

Comment 3

[Abhishek Sharma[:mick]]

First I have to solve Bug #1688504 than I came to solve this bug.

Comment 4

[Pawan Verma]

@Abhishek Sharma If you are not active on this bug can I take it?

Comment 5

[Abhishek Sharma[:mick]]

I am on active this bug.

Comment 6

[Abhishek Sharma[:mick]]

Attachment: "Bug 1688511 - StartupCacheUtils.cpp: do not use 'else' after 'return' :Sylvestre"

Comment 7

[Abhishek Sharma[:mick]]

Attachment: "Bug 1688511 - StartupCacheUtils.cpp: do not use 'else' after 'return' ":Sylvestre""

Remove the else if statement

Depends on D103866

Comment 8

[Sylvestre Ledru [:Sylvestre]]

Abhishek, as I was saying in the review, I am unassigning these bugs from you.
You need to compile and test your changes and you haven't despite asking several times.

Comment 9

[Sylvestre Ledru [:Sylvestre]]

You should start with easier contribution than Firefox and follow the guidance ;)

Comment 10

[Sachin Chauhan]

Attachment: Bug 1688511 - do not use 'else' after 'return'. r?Sylvestre

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/96c5cac78a5c
do not use 'else' after 'return'. r=sylvestre

Comment 12

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/96c5cac78a5c