Closed Bug 1688538 Opened 5 years ago Closed 5 years ago

Add a comment to inactive-property-helper.js to say that we shouldn't use it for inherited-by-default properties

Categories

(DevTools :: Inspector: Rules, task)

task

Tracking

(firefox87 fixed)

RESOLVED FIXED
87 Branch
Tracking Status
firefox87 --- fixed

People

(Reporter: dholbert, Assigned: dholbert)

References

Details

Attachments

(1 file)

Spinning this off from discussion in bug 1583901 (see bug 1583901 comment 10 & bug 1583901 comment 12).

I've got a code-comment that I think we should add, to warn us against adding probably-undesirable "inactive css" rules. Patch coming shortly.

See Also: → 1583901
Pushed by dholbert@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/70914a5bab71 Add a code-comment to explain why devtools shouldn't warn for "inactive" properties that are inherited-by-default. r=jdescottes
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → 87 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: